Repository navigation
Validate complete recording duration and drain FFmpeg source output - #923
Merged
matteius merged 4 commits intoNov 7, 2026
Merged
Conversation
…pilot Autofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
…pilot Autofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
matteius
marked this pull request as ready for review
November 7, 2026 21:53
matteius
changed the title
matteius
deleted the
ai-findings-autofix/tests-performance-active-recording.mjs
branch
November 7, 2026 21:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the source HTTP response open until FFmpeg stdout drains, and reject truncated recordings using the total recorded duration for each camera.
Duration validation sums each stream's segments with a five-second startup/stop allowance, so normal 60-second segments and a short final segment remain valid. Missing cameras and missing, zero, negative or non-finite durations fail. Source spawn failures and unexpected exits fail the run, including failures reported during cleanup; intentional client disconnects remain normal shutdown. Every recorded file still receives strict FFmpeg decoding.
Validation: six Node regression tests pass. A 65-second, one-camera loopback recording against the local recording-integrity binary passed full decoding and duration validation with 60.066667-second and 4.4-second segments (64.466667 seconds total). Syntax and whitespace checks pass.