Repository navigation
Fix deadlock after partial health-worker startup failure - #694
Merged
Merged
Conversation
Keep workers at a startup gate until all threads exist. On a later pthread_create failure, gated workers can exit and be joined without waiting for the lifecycle lock held by startup. Preserve same-runtime retries and concurrent start/shutdown ownership. Nine real-thread fault/ownership cases plus four existing type controls pass under ASan/UBSan on main. The new suite reproduced five failures before the fix. Register the regression in the existing native CI job.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A later
pthread_createfailure could hang health startup: cleanup joined an already-created worker while holding the lifecycle mutex that the worker needed to enter collection.Keep workers at a startup gate until all four threads exist. Partial failure clears the running flag and wakes/joins gated workers without releasing lifecycle ownership. The initialized runtime remains retryable.
main: the new suite reproduces five failures before the fix; afterward all nine new cases plus four existing type cases pass under ASan/UBSan. Actionlint passes.Test selection:
ctest --test-dir build/test --output-on-failure --no-tests=error -R '^test_system_health_(startup|types)$'.Extracted from #693. This PR has no dependency on its foundation tooling, plans or generated artifacts.