Skip to content

Potential fixes for 2 code quality findings - #37

Merged
matteius merged 5 commits into
mainfrom
ai-findings-autofix/django_forms_workflows-form_builder_views.py
Nov 2, 2026
Merged

matteius merged 5 commits into
mainfrom
ai-findings-autofix/django_forms_workflows-form_builder_views.py

Conversation

@matteius

@matteius matteius commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

This PR applies 2/3 suggestions from code quality AI findings. 1 suggestion was skipped to avoid creating conflicts.

matteius and others added 4 commits November 2, 2026 01:51
…rom Copilot Autofix

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
…rom Copilot Autofix

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Filter stages on the real workflow FK; workflow_definition raised FieldError
and turned every builder save into a 500.

Raise FormBuilderPayloadError instead of returning a JsonResponse from the
helper. Its caller unpacks a tuple, so the rejection could never reach the
client, and raising also rolls back the partial save.

Add tests for stage and field scoping, rollback, and cloned reviewer groups.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Resolves CVE-2026-119194, CVE-2026-119195, CVE-2026-119196 and
CVE-2026-119197, which fail the CI dependency audit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Stop stringifying the caught exception in form_builder_save, which CodeQL
flagged as py/stack-trace-exposure. The specific validation messages stay
available to the builder UI through FormBuilderPayloadError.client_message.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@matteius
matteius marked this pull request as ready for review November 2, 2026 10:35
@matteius
matteius merged commit 2110a46 into main Nov 2, 2026
17 checks passed
@matteius
matteius deleted the ai-findings-autofix/django_forms_workflows-form_builder_views.py branch November 2, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants