Skip to content

Potential fixes for 2 code quality findings - #36

Merged
matteius merged 4 commits into
mainfrom
ai-findings-autofix/django_forms_workflows-tasks.py
Nov 2, 2026
Merged

matteius merged 4 commits into
mainfrom
ai-findings-autofix/django_forms_workflows-tasks.py

Conversation

@matteius

@matteius matteius commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

This PR applies 2/2 suggestions from code quality AI findings.

matteius and others added 4 commits November 2, 2026 01:50
…utofix

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
…utofix

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Restore the role="approval" guard on notify_stage_groups while limiting
recipients to groups that hold a task, so tasks left over from before the
0.74.6 engine fix cannot page validation or reassignment groups. Fold the
stage and group lookups into one query, which also removes the unused
StageApprovalGroup import that failed lint.

Reuse the resolved task for the email context instead of fetching it again
for each rule, and cover both behaviours and a deleted task with tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Resolves CVE-2026-119194, CVE-2026-119195, CVE-2026-119196 and
CVE-2026-119197, which fail the CI dependency audit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@matteius
matteius marked this pull request as ready for review November 2, 2026 07:37
@matteius
matteius merged commit 7e5c10e into main Nov 2, 2026
17 checks passed
@matteius
matteius deleted the ai-findings-autofix/django_forms_workflows-tasks.py branch November 2, 2026 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant