Deprecate filter_by_backend_roles, targeting removal in 4.0 - #1818
Open
DarshitChanpura wants to merge 1 commit into
Open
DarshitChanpura wants to merge 1 commit into
DarshitChanpura wants to merge 1 commit into
Conversation
Backend-role filtering is superseded by the security plugin's resource sharing and access control, which authorizes a resource by the access level it is shared at rather than by backend-role overlap. Detectors and correlation rules are onboarded to resource sharing, so the setting is now the legacy path. - plugins.security_analytics.filter_by_backend_roles gets Setting.Property.Deprecated - javadoc names 4.0 as the removal target, the replacement, and the threat intel dependency below Removal needs threat intel onboarded to resource sharing first: TIF source configs, IOC findings and threat-intel monitors and alerts still authorize through this setting, and only detector and correlation-rule are registered as shareable types. Tracking: opensearch-project/security#6530 Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
DarshitChanpura
requested review from
AWSHurneyt,
KashKondaka,
amsiglan,
eirsep,
engechas,
getsaurabh02,
goyamegh,
lezzago,
manaswini1920,
nishtham-amazon,
riysaxen-amzn,
toepkerd and
vikhy-aws
as code owners
September 18, 2026 19:03
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (68.60%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1818 +/- ##
============================================
+ Coverage 68.58% 68.60% +0.01%
- Complexity 3750 3751 +1
============================================
Files 417 417
Lines 20888 20888
Branches 2189 2189
============================================
+ Hits 14327 14331 +4
+ Misses 5461 5457 -4
Partials 1100 1100 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Marks backend-role filtering deprecated, targeting removal in 4.0. It is superseded by the security plugin's resource sharing and access control, which authorizes a resource by the access level it is shared at rather than by backend-role overlap, and detectors and correlation rules are already onboarded.
plugins.security_analytics.filter_by_backend_rolesgetsSetting.Property.DeprecatedNo behavior change:
Property.Deprecatedonly emits a deprecation warning when the setting is set.Removal in 4.0 needs threat intel onboarded to resource sharing first. TIF source configs, IOC findings, and threat-intel monitors and alerts still authorize through this setting, and only
detectorandcorrelation-ruleare registered as shareable types, so dropping the setting today would leave those surfaces without an authorization path.Testing
compileJavaandcompileTestJavaare clean. The only other reference to the setting isSecurityAnalyticsRestTestCase, which sets it against a live cluster; CI covers that path.Related
Tracking issue: opensearch-project/security#6530
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.