Repository navigation
Add additional keycloak pages - #38
Merged
Merged
Conversation
Ekhorn
force-pushed
the
28-migrate-kc-themes-to-vaadin-part-3
branch
from
October 2, 2026 14:01
26c3e7f to
2f80501
Compare
Ekhorn
marked this pull request as ready for review
October 9, 2026 12:41
wborn
reviewed
Oct 9, 2026
wborn
left a comment
wborn
left a comment
Member
There was a problem hiding this comment.
This is an initial AI-assisted review.
The six additional pages follow Keycloak's corresponding templates for form actions, navigation, message handling, and profile fields. The implementation consistently reuses the existing shared layout and form helpers.
Both CI/CD and the Keycloak drift check pass.
AI found no further issues. Manual maintainer review is still needed before merge. The authentication and identity-provider flows have not been independently tested against a running Keycloak instance.
Ekhorn
force-pushed
the
28-migrate-kc-themes-to-vaadin-part-3
branch
from
October 9, 2026 16:12
2f80501 to
7fb1070
Compare
13 tasks
Ekhorn
force-pushed
the
28-migrate-kc-themes-to-vaadin-part-3
branch
from
October 13, 2026 17:44
7fb1070 to
47f1a83
Compare
Ekhorn
force-pushed
the
28-migrate-kc-themes-to-vaadin-part-3
branch
from
October 14, 2026 10:27
47f1a83 to
a86a6e6
Compare
richturner
force-pushed
the
28-migrate-kc-themes-to-vaadin-part-3
branch
from
October 15, 2026 08:54
a86a6e6 to
9fd7162
Compare
richturner
requested changes
Oct 19, 2026
richturner
left a comment
richturner
left a comment
Member
There was a problem hiding this comment.
Can we use the same filename as the pageIds?
Member
Ekhorn
force-pushed
the
28-migrate-kc-themes-to-vaadin-part-3
branch
2 times, most recently
from
October 22, 2026 08:06
9c4bf71 to
033ac0f
Compare
richturner
previously approved these changes
Oct 27, 2026
Base automatically changed from
28-migrate-kc-themes-to-vaadin-part-2
to
main
October 28, 2026 09:51
- info.ftl - login-page-expired.ftl - login-update-profile.ftl - idp-review-user-profile.ftl - login-idp-link-confirm.ftl - login-idp-link-email.ftl
richturner
force-pushed
the
28-migrate-kc-themes-to-vaadin-part-3
branch
from
October 28, 2026 09:51
033ac0f to
cd963ac
Compare
richturner
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Nine pages were still falling through to Keycloak's own theme, so several ordinary flows ended on an unbranded page:
Everything else still falls through to
keycloak.v2.Changelog
info,login-page-expired,login-update-profile,idp-review-user-profile,login-idp-link-confirm,login-idp-link-email,login-idp-link-confirm-override,link-idp-actionandlogin-verify-email.pageId.