Skip to content

Use OpenRemote 1.33.0 - #97

Merged
Ekhorn merged 6 commits into
mainfrom
update-openremote
Oct 29, 2026
Merged

Ekhorn merged 6 commits into
mainfrom
update-openremote

Conversation

@wborn

@wborn wborn commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

Changes

  • Upgrade OpenRemote from 1.30.0 to 1.33.0.
  • Update OpenRemote dependencies across all UI packages.
  • Update development Docker Compose profiles to use OpenRemote 1.33.0.
  • Upgrade Gradle wrapper from 9.6.1 to 9.8.1.
  • Upgrade TypeScript Generator from 4.1.1 to 4.2.1.
  • Upgrade Axion Release plugin from 1.21.2 to 1.21.4.
  • Upgrade Jackson from 2.21.4 to 2.21.7.
  • Align Rspack CLI and core to ~2.1.10, matching OpenRemote core.
  • Add @rspack/dev-server ~2.1.0 to both UI apps.
  • Remove the root Axios resolution and use the version required by OpenRemote dependencies.
  • Add Node.js type definitions for UI tooling.
  • Compile TypeScript project references before building or serving the custom app to avoid Axios type errors.
  • Replace deprecated React CSS configuration with explicit CSS rules for Rspack 2.
  • Refresh Yarn lockfile with updated transitive dependencies, including Axios, MapLibre, Vaadin, Gridstack, and i18next.
  • Migrate GitHub Actions pipelines to separate review, staging, and deployment workflows, using reusable workflows from OpenRemote 1.33.0.
  • Configure Keycloak hostname and manager URL for local development and testing.
  • Move UI build outputs to build directories and update Gradle tasks, TypeScript configurations, and package exports accordingly.
  • Update Rspack configurations for the new build output locations, relative asset paths, and UMD library compatibility.

Fixes #49

@wborn
wborn requested a review from a team October 27, 2026 15:19

@Ekhorn Ekhorn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider adopting the new pipeline changes for openremote/core#3450 based on openremote/core#2955.

@wborn
wborn requested a review from Ekhorn October 28, 2026 08:29
Comment thread profile/dev-ui.yml Resolved
wborn added 2 commits October 28, 2026 15:33
Move compiled modules, bundles and incremental caches into each package's build directory. Update package metadata, deployment copying and Gradle cleanup accordingly.

Fix REST UMD bundling and remove the unused model bundle declaration.
Pin Rspack versions, add compatible Node typings and deduplicate Yarn dependencies.

Use relative production asset URLs so the React app loads correctly under /custom-react/.

Validated production builds, deployment copies, package contents, Gradle cleanup and the custom app serve flow.

Fixes #49
@wborn
wborn requested a review from Ekhorn October 28, 2026 14:56

@Ekhorn Ekhorn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version bumps match core 1.33.0 (the Gradle wrapper files are identical to core's), the UI build output move mirrors openremote/core#3145, the publicPath change fixes #49, and both earlier review points (pipeline migration and KC_HOSTNAME) are addressed.

One change needs attention before merge: the root axios resolution now downgrades the axios version that OpenRemote 1.33.0 pins. The rspack pin and the Keycloak dev profile comments are non-blocking.

This review was AI-assisted.

Comment thread package.json Resolved
Comment thread package.json Resolved
Comment thread profile/dev-ui.yml Resolved
wborn added 2 commits October 29, 2026 10:41
- Align Rspack and dev-server versions with OpenRemote core
- Remove Axios and Rspack resolution overrides
- Compile TypeScript project references before building or serving
- Migrate React CSS configuration to Rspack 2
- Update Yarn lockfile
@wborn
wborn requested a review from Ekhorn October 29, 2026 10:32

@Ekhorn Ekhorn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both earlier package.json points are addressed: with the root resolutions removed, yarn.lock resolves a single axios 1.20.0 and a single rspack 2.1.10 across the workspace, and custom-react now builds on rspack 2 with an explicit css/auto rule. OR_MANAGER_URL is set in both dev profiles, and the checks pass on 697412b.

AI found no further issues.

This review was AI-assisted.

@Ekhorn
Ekhorn merged commit 83a5140 into main Oct 29, 2026
7 checks passed
@wborn
wborn deleted the update-openremote branch October 29, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom React App does not load when running manager using OR_CUSTOM_APP_DOCROOT

2 participants