Repository navigation
Use OpenRemote 1.33.0 - #97
Conversation
Ekhorn
left a comment
There was a problem hiding this comment.
Please consider adopting the new pipeline changes for openremote/core#3450 based on openremote/core#2955.
Move compiled modules, bundles and incremental caches into each package's build directory. Update package metadata, deployment copying and Gradle cleanup accordingly. Fix REST UMD bundling and remove the unused model bundle declaration. Pin Rspack versions, add compatible Node typings and deduplicate Yarn dependencies. Use relative production asset URLs so the React app loads correctly under /custom-react/. Validated production builds, deployment copies, package contents, Gradle cleanup and the custom app serve flow. Fixes #49
Ekhorn
left a comment
There was a problem hiding this comment.
The version bumps match core 1.33.0 (the Gradle wrapper files are identical to core's), the UI build output move mirrors openremote/core#3145, the publicPath change fixes #49, and both earlier review points (pipeline migration and KC_HOSTNAME) are addressed.
One change needs attention before merge: the root axios resolution now downgrades the axios version that OpenRemote 1.33.0 pins. The rspack pin and the Keycloak dev profile comments are non-blocking.
This review was AI-assisted.
- Align Rspack and dev-server versions with OpenRemote core - Remove Axios and Rspack resolution overrides - Compile TypeScript project references before building or serving - Migrate React CSS configuration to Rspack 2 - Update Yarn lockfile
Ekhorn
left a comment
There was a problem hiding this comment.
Both earlier package.json points are addressed: with the root resolutions removed, yarn.lock resolves a single axios 1.20.0 and a single rspack 2.1.10 across the workspace, and custom-react now builds on rspack 2 with an explicit css/auto rule. OR_MANAGER_URL is set in both dev profiles, and the checks pass on 697412b.
AI found no further issues.
This review was AI-assisted.
Changes
1.30.0to1.33.0.1.33.0.9.6.1to9.8.1.4.1.1to4.2.1.1.21.2to1.21.4.2.21.4to2.21.7.~2.1.10, matching OpenRemote core.@rspack/dev-server~2.1.0to both UI apps.1.33.0.builddirectories and update Gradle tasks, TypeScript configurations, and package exports accordingly.Fixes #49