Skip to content

Harden rules facade #2819

Closed as not planned
Closed as not planned

Description

@ebariaux

Review all facades injected in the rules to ensure that they apply the proper restriction on functionality exposed to user.
Most importantly, restrict data access per scope of engine executing the rules.
Ensure there's test coverage.

Activity

  1. ebariaux commented on Jun 3, 2026

    @ebariaux
    ContributorAuthor

    manager/src/main/java/org/openremote/manager/rules/facade/WebhooksFacade.java:47 can build a target from an arbitrary webhook URL, which needs SSRF controls.

  2. ebariaux commented on Oct 26, 2026

    @ebariaux
    ContributorAuthor

    Duplicate of #2675. The rules facade scoping work is consolidated there, including the related PRs, the asset sub-issues, and the WebhooksFacade review conclusion: no meaningful realm/asset scoping change is required for this outbound HTTP client. See #2675 for the remaining integration work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions