Pre CRAN release 0.2.4 - #119
Open
clarkliming wants to merge 6 commits into
Open
clarkliming wants to merge 6 commits into
clarkliming wants to merge 6 commits into
Conversation
Contributor
Code Coverage SummaryDiff against mainResults for commit: 6494915 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Contributor
Unit Test Performance Difference
Results for commit 9d93d63 ♻️ This comment has been updated with latest results. |
Contributor
Unit Tests Summary 1 files 13 suites 12s ⏱️ Results for commit 6494915. ♻️ This comment has been updated with latest results. |
Collaborator
|
@clarkliming I guess this now needs to be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepares the 0.2.4 CRAN release and fixes the r-devel check failure reported on the CRAN check page.
The r-devel failure
tests/testthat/test-predict_counterfactual.R:73errored on all five r-devel flavors (Debian clang/gcc, Fedora clang/gcc, Windows) with:while every r-patched / r-release flavor was OK, including Linux. So this is release vs. r-devel, not a platform difference.
R-devel changed
model.frame.glm()to use the same logic asmodel.frame.lm()(PR#19036), which passes the fit's storedxlevelsdown tomodel.frame(). The test relabelled a treatment level after fitting and then handed the relabelled data back topredict_counterfactual(), sodatano longer agreed withfit$xlevels. Release R let this through forglmfits only because the oldmodel.frame.glm()re-evaluatedglm(..., method = "model.frame")and droppedxlevalong the way;lmfits have always errored on the same input.The test now refits the model on the relabelled data so that the fit and the data agree, while still exercising a non-alphabetical treatment level order (
trtpbo,trt1,trt2) — which is what the test is named for, and what thegl()fix from #111 guards.Release prep
Versionto 0.2.4 andDateto 2026-08-19.NEWS.mddevelopment heading to# RobinCar2 0.2.4, and add a### Miscentry documenting the consequence for users:predict_counterfactual()now requires the treatment factor levels indatato match those offit.inst/WORDLISTentries.CRAN submission status
This release cannot be submitted yet — CRAN submissions are currently on hold. The CRAN submission portal states:
The stated window ends today, 2026-08-19, so the intention is to submit as soon as the portal reopens. In the meantime this PR and the
v0.2.4-rc1pre-release tag stage the submission candidate, so the tarball is ready to go without further changes once submissions resume.Test plan
devtools::test()on R 4.6.1 — all pass, 1 skip ({speff2trial}not installed locally).R CMD check --as-cranon R 4.6.1 (aarch64 macOS), with--no-vignettes --no-build-vignettesand_R_CHECK_FORCE_SUGGESTS_=false—checking tests ... OKandchecking examples ... OK. The remaining ERROR/WARNINGs are all gaps in the local toolchain rather than package problems: nopandoc(soREADME.md/NEWS.mdand the vignettes are unchecked), nopdflatex(so the PDF manual cannot be built), and an outdated HTML Tidy. CI covers those.lintr::lint_package()— no lints in the changed files.spelling::spell_check_package()— clean.🤖 Generated with Claude Code