Skip to content

fix articles page sort, filter, search - #5473

Open
StephDriver wants to merge 10 commits into
r-v1.9.xfrom
b-5464_fix_olh_articles_sort
Open

fix articles page sort, filter, search#5473
StephDriver wants to merge 10 commits into
r-v1.9.xfrom
b-5464_fix_olh_articles_sort

Conversation

@StephDriver

Copy link
Copy Markdown
Member

closes #5464
closes #5471

@StephDriver
StephDriver marked this pull request as ready for review August 25, 2026 13:59
@StephDriver StephDriver assigned mauromsl and unassigned StephDriver Aug 25, 2026
@StephDriver

Copy link
Copy Markdown
Member Author

These changes are all about the articles page.

  • fix a bug in OLH that meant the sort wasn't working.
  • improve accessibility so that page is compatible with keyboard and screen reader
  • improve accessibility (readability) by changing button labels to sort, filter and search instead of a mix of apply and those terms. Nice and clear which one applies which.
  • changes css so that the clear all and apply all buttons in the filter are quieter than the filter itself.
  • tweak css so that the elements within the sort block are neatly aligned (as previously in Clarity, but not great in other themes).

Added two template tags

  • one is for including aria in form fields - this was needed to make the date fields screen reader compatible, but is likely to be useful elsewhere. A template tag is needed because you need to pass in the relevant ID to the relevant field, and hte id may only be known through loops of the calling template, i.e. not static.
  • other is for adding ids that aren't duplicates to elements that otherwise would be duplicated due to the way they are generated (e.g. in a loop). IDs being needed for describedby and labelledby but also needing to be unique on the page for valid HTML.

@mauromsl
mauromsl requested a review from joemull September 3, 2026 07:37
@mauromsl mauromsl assigned joemull and unassigned mauromsl Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

filter date fields not providing labels to screen readers Articles "sort" not working

3 participants