8372044: Implementation Review Based on ML-KEM Security Considerations - #755
Open
stooke wants to merge 1 commit into
Open
8372044: Implementation Review Based on ML-KEM Security Considerations#755stooke wants to merge 1 commit into
stooke wants to merge 1 commit into
Conversation
|
👋 Welcome back stooke! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to backport this enhancement to JDK25 as part of a series of Post Quantum Cryptography PRs. This PR enhances the security of the ML-KEM implementation so should be part of this ongoing effort.
Medium to low risk.
[Testing]
Tier 2 tests pass, except for several network related tests that also fail in the master branch on my machine.
Specifically, acvp/Launcher.java passes with the ACVP-Server-1.1.0.38 bundle supplied.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/755/head:pull/755$ git checkout pull/755Update a local copy of the PR:
$ git checkout pull/755$ git pull https://git.openjdk.org/jdk25u-dev.git pull/755/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 755View PR using the GUI difftool:
$ git pr show -t 755Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/755.diff
Using Webrev
Link to Webrev Comment