Skip to content

8390521: RISC-V: Clean up vector register dispatch in MachSpillCopyNode::implementation - #748

Open
zifeihan wants to merge 1 commit into
openjdk:masterfrom
zifeihan:backport-JDK-8390521
Open

8390521: RISC-V: Clean up vector register dispatch in MachSpillCopyNode::implementation#748
zifeihan wants to merge 1 commit into
openjdk:masterfrom
zifeihan:backport-JDK-8390521

Conversation

@zifeihan

@zifeihan zifeihan commented Aug 22, 2026

Copy link
Copy Markdown
Member

Hi, this patch is a backport of openjdk/jdk#32416
Because JDK-8379867 hasn't been backported to jdk25u-dev yet, this has been adjusted compared to the original openjdk/jdk#32416 (bottom_type()->isa_pvectmask() → bottom_type()->isa_vectmask()).
The main purposes of this backport are: 1. to eliminate some unnecessary type checks. 2. With this backport, readability and maintainability are also improved.

Testing

  • make test TEST="hotspot_vector_1 hotspot_vector_2 jdk_vector jdk_vector_sanity" with fastdebug
  • make test TEST="hotspot:tier1 hotspot:tier2 hotspot:tier3" with fastdebug

This is a risc-v specific change. risk is low.



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8390521 needs maintainer approval

Issue

  • JDK-8390521: RISC-V: Clean up vector register dispatch in MachSpillCopyNode::implementation (Enhancement - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/748/head:pull/748
$ git checkout pull/748

Update a local copy of the PR:
$ git checkout pull/748
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/748/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 748

View PR using the GUI difftool:
$ git pr show -t 748

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/748.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Aug 22, 2026

Copy link
Copy Markdown

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Aug 22, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport 87952df444ec7bc0db3f25bbeebd10204180e609 8390521: RISC-V: Clean up vector register dispatch in MachSpillCopyNode::implementation Aug 22, 2026
@openjdk

openjdk Bot commented Aug 22, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added the backport Port of a pull request already in a different code base label Aug 22, 2026
@zifeihan
zifeihan marked this pull request as ready for review August 22, 2026 02:02
@openjdk openjdk Bot added the rfr Pull request is ready for review label Aug 22, 2026

@RealFYang RealFYang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@openjdk

openjdk Bot commented Aug 22, 2026

Copy link
Copy Markdown

⚠️ @zifeihan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@zifeihan

Copy link
Copy Markdown
Member Author

/approval request
Hi, this patch is a backport of openjdk/jdk#32416
Because JDK-8379867 hasn't been backported to jdk25u-dev yet, this has been adjusted compared to the original openjdk/jdk#32416 (bottom_type()->isa_pvectmask() → bottom_type()->isa_vectmask()).
The main purposes of this backport are: 1. to eliminate some unnecessary type checks. 2. With this backport, readability and maintainability are also improved.
Testing:

make test TEST="hotspot_vector_1 hotspot_vector_2 jdk_vector jdk_vector_sanity" with fastdebug ok
make test TEST="hotspot:tier1 hotspot:tier2 hotspot:tier3" with fastdebug ok

@mlbridge

mlbridge Bot commented Aug 22, 2026

Copy link
Copy Markdown

Webrevs

@openjdk

openjdk Bot commented Aug 22, 2026

Copy link
Copy Markdown

@zifeihan
8390521: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Aug 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants