Skip to content

8375443: AVX-512: Disabling through UseSHA doesn't affect UseSHA3Intrinsics - #745

Open
rm-gh-8 wants to merge 1 commit into
openjdk:masterfrom
rm-gh-8:JDK-8375443-V25
Open

8375443: AVX-512: Disabling through UseSHA doesn't affect UseSHA3Intrinsics#745
rm-gh-8 wants to merge 1 commit into
openjdk:masterfrom
rm-gh-8:JDK-8375443-V25

Conversation

@rm-gh-8

@rm-gh-8 rm-gh-8 commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Backporting JDK-8375443: AVX-512: Disabling through UseSHA doesn't affect UseSHA3Intrinsics.

This PR fixes a bug where UseSHA3Intrinsics could be auto enabled on capable AVX-512 CPUs even when the master UseSHA flag is disabled.

For parity with Oracle JDK.

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST=test/hotspot/jtreg/compiler/arguments/TestUseSHA3IntrinsicsWithUseSHADisabledOnSupportedCPU.java
make test TEST=test/hotspot/jtreg/compiler/arguments/TestUseSHA3IntrinsicsWithUseSHADisabledOnUnsupportedCPU.java

Results:

windows-x64-specific-test.log
windows-x64-specific-2-test.log
macos-aarch64-specific-test.log
macos-aarch64-specific-2-test.log
linux-x64-specific-test.log
linux-x64-specific-2-test.log
linux-aarch64-specific-test.log
linux-aarch64-specific-2-test.log



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8375443 needs maintainer approval

Issue

  • JDK-8375443: AVX-512: Disabling through UseSHA doesn't affect UseSHA3Intrinsics (Bug - P5 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/745/head:pull/745
$ git checkout pull/745

Update a local copy of the PR:
$ git checkout pull/745
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/745/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 745

View PR using the GUI difftool:
$ git pr show -t 745

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/745.diff

Using Webrev

Link to Webrev Comment

@rm-gh-8
rm-gh-8 marked this pull request as ready for review August 21, 2026 14:51
@bridgekeeper

bridgekeeper Bot commented Aug 21, 2026

Copy link
Copy Markdown

👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Aug 21, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport ee5b10c7f0ac5dba69d69fdd4b8a30b6443e6720 8375443: AVX-512: Disabling through UseSHA doesn't affect UseSHA3Intrinsics Aug 21, 2026
@openjdk

openjdk Bot commented Aug 21, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 21, 2026
@openjdk

openjdk Bot commented Aug 21, 2026

Copy link
Copy Markdown

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Aug 21, 2026
@mlbridge

mlbridge Bot commented Aug 21, 2026

Copy link
Copy Markdown

Webrevs

@rm-gh-8

rm-gh-8 commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

/approval request for backport of JDK-8375443: AVX-512: Disabling through UseSHA doesn't affect UseSHA3Intrinsics.

This PR fixes a bug where UseSHA3Intrinsics could be auto enabled on capable AVX-512 CPUs even when the master UseSHA flag is disabled.

For parity with Oracle JDK.

Low risk — a flag consistency fix in x86 CPU.

@openjdk

openjdk Bot commented Aug 21, 2026

Copy link
Copy Markdown

@rm-gh-8
8375443: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant