8375443: AVX-512: Disabling through UseSHA doesn't affect UseSHA3Intrinsics - #745
8375443: AVX-512: Disabling through UseSHA doesn't affect UseSHA3Intrinsics#745rm-gh-8 wants to merge 1 commit into
Conversation
|
👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8375443: AVX-512: Disabling through UseSHA doesn't affect UseSHA3Intrinsics. This PR fixes a bug where UseSHA3Intrinsics could be auto enabled on capable AVX-512 CPUs even when the master UseSHA flag is disabled. For parity with Oracle JDK. Low risk — a flag consistency fix in x86 CPU. |
Backporting JDK-8375443: AVX-512: Disabling through UseSHA doesn't affect UseSHA3Intrinsics.
This PR fixes a bug where UseSHA3Intrinsics could be auto enabled on capable AVX-512 CPUs even when the master UseSHA flag is disabled.
For parity with Oracle JDK.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/hotspot/jtreg/compiler/arguments/TestUseSHA3IntrinsicsWithUseSHADisabledOnSupportedCPU.java
make test TEST=test/hotspot/jtreg/compiler/arguments/TestUseSHA3IntrinsicsWithUseSHADisabledOnUnsupportedCPU.java
Results:
windows-x64-specific-test.log
windows-x64-specific-2-test.log
macos-aarch64-specific-test.log
macos-aarch64-specific-2-test.log
linux-x64-specific-test.log
linux-x64-specific-2-test.log
linux-aarch64-specific-test.log
linux-aarch64-specific-2-test.log
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/745/head:pull/745$ git checkout pull/745Update a local copy of the PR:
$ git checkout pull/745$ git pull https://git.openjdk.org/jdk25u-dev.git pull/745/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 745View PR using the GUI difftool:
$ git pr show -t 745Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/745.diff
Using Webrev
Link to Webrev Comment