Skip to content

8382257: Shenandoah: Clean up stack watermark barrier support - #739

Open
shipilev wants to merge 1 commit into
openjdk:masterfrom
shipilev:JDK-8382257-shenandoah-stackwatermark
Open

8382257: Shenandoah: Clean up stack watermark barrier support#739
shipilev wants to merge 1 commit into
openjdk:masterfrom
shipilev:JDK-8382257-shenandoah-stackwatermark

Conversation

@shipilev

@shipilev shipilev commented Aug 19, 2026

Copy link
Copy Markdown
Member

Following the nmethod barrier code cleanup, this also cleans up stack watermark machinery, which is not unconditionally on. There is a little conflict in tests due to the absence of JDK-8369013, which has some bugtail in itself. So on balance, it is easier to accept the conflict here.

Additional testing:

  • Linux x86_64 server fastdebug, hotspot_gc_shenandoah


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8382257 needs maintainer approval

Issue

  • JDK-8382257: Shenandoah: Clean up stack watermark barrier support (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/739/head:pull/739
$ git checkout pull/739

Update a local copy of the PR:
$ git checkout pull/739
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/739/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 739

View PR using the GUI difftool:
$ git pr show -t 739

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/739.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Aug 19, 2026

Copy link
Copy Markdown

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Aug 19, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport 10e23dd5823258cfbf500175dde23be12cdd99bf 8382257: Shenandoah: Clean up stack watermark barrier support Aug 19, 2026
@openjdk

openjdk Bot commented Aug 19, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Aug 19, 2026
@mlbridge

mlbridge Bot commented Aug 19, 2026

Copy link
Copy Markdown

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant