Skip to content

8389905: Shenandoah: SBSA::card_table uses own temp registers that clobber obj - #729

Open
shipilev wants to merge 1 commit into
openjdk:masterfrom
shipilev:JDK-8389905-shen-card-table-clobber
Open

8389905: Shenandoah: SBSA::card_table uses own temp registers that clobber obj#729
shipilev wants to merge 1 commit into
openjdk:masterfrom
shipilev:JDK-8389905-shen-card-table-clobber

Conversation

@shipilev

@shipilev shipilev commented Aug 13, 2026

Copy link
Copy Markdown
Member

Fixes a clobbering bug in Shenandoah card table barriers.

Additional testing:

  • Linux x86_64 server fastdebug, jcstress 8 hour run
  • Linux x86_64 server fastdebug, hotspot_gc_shenandoah
  • Linux x86_64 server fastdebug, hotspot_gc_shenandoah with -XX:TieredStopAtLevel=1
  • Linux x86_64 server fastdebug, all with -XX:+UseShenandoahGC
  • Linux AArch64 server fastdebug, all with -XX:+UseShenandoahGC
  • Linux x86_64 server fastdebug, all with -XX:+UseShenandoahGC -XX:TieredStopAtLevel=1
  • Linux AArch64 server fastdebug, all with -XX:+UseShenandoahGC -XX:TieredStopAtLevel=1


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8389905 needs maintainer approval

Issue

  • JDK-8389905: Shenandoah: SBSA::card_table uses own temp registers that clobber obj (Bug - P2 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/729/head:pull/729
$ git checkout pull/729

Update a local copy of the PR:
$ git checkout pull/729
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/729/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 729

View PR using the GUI difftool:
$ git pr show -t 729

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/729.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Aug 13, 2026

Copy link
Copy Markdown

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Aug 13, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport c1643bbae4e649aeee728e938010a18de8f5a17e 8389905: Shenandoah: SBSA::card_table uses own temp registers that clobber obj Aug 13, 2026
@openjdk

openjdk Bot commented Aug 13, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 13, 2026
@shipilev
shipilev marked this pull request as ready for review August 19, 2026 08:52
@openjdk

openjdk Bot commented Aug 19, 2026

Copy link
Copy Markdown

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Aug 19, 2026
@mlbridge

mlbridge Bot commented Aug 19, 2026

Copy link
Copy Markdown

Webrevs

@shipilev

Copy link
Copy Markdown
Member Author

/approval request Fixes a clobbering bug in Shenandoah card table barriers. Readily manifested with Valhalla, but the bug is actually generic. Patch is relatively new, but the fix is straightforward. Applies cleanly, aggressive testing passes. Risk is medium-low: affects production paths, confined to Generational Shenandoah, was in mainline for 10+ days without issues; backporting it provides a firmer testing ground for other changes in barrier set.

@openjdk

openjdk Bot commented Aug 19, 2026

Copy link
Copy Markdown

@shipilev
8389905: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant