8387721: C2: Print Node barrier data - #718
Conversation
|
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
phohensee
left a comment
There was a problem hiding this comment.
25u's dump_adr_type doesn't use it's mem argument: I guess that got cleaned up somewhere else.
|
|
|
/approval request Improves compiler-side diagnostics with Late Barrier Expansion GCs (ZGC and G1 in JDK 25u). Small patch, but requires minor adaptations. Testing passes. Risk is on lower side: compiler diagnostic code, non-product code, no customer exposure. |
Improves diagnostics with Late Barrier Expansion GCs (ZGC and G1 in JDK 25u).
There are minor conflicts, due to
MemNode::dump_adr_typesignature difference which acceptsconst Node* memas the argument in JDK 25u.Additional testing:
hotspot_compilerProgress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/718/head:pull/718$ git checkout pull/718Update a local copy of the PR:
$ git checkout pull/718$ git pull https://git.openjdk.org/jdk25u-dev.git pull/718/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 718View PR using the GUI difftool:
$ git pr show -t 718Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/718.diff
Using Webrev
Link to Webrev Comment