Skip to content

8387721: C2: Print Node barrier data - #718

Open
shipilev wants to merge 1 commit into
openjdk:masterfrom
shipilev:JDK-8387721-print-node-barrier
Open

8387721: C2: Print Node barrier data#718
shipilev wants to merge 1 commit into
openjdk:masterfrom
shipilev:JDK-8387721-print-node-barrier

Conversation

@shipilev

@shipilev shipilev commented Aug 11, 2026

Copy link
Copy Markdown
Member

Improves diagnostics with Late Barrier Expansion GCs (ZGC and G1 in JDK 25u).

There are minor conflicts, due to MemNode::dump_adr_type signature difference which accepts const Node* mem as the argument in JDK 25u.

Additional testing:

  • Linux x86_64 server fastdebug, hotspot_compiler


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8387721 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8387721: C2: Print Node barrier data (Enhancement - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/718/head:pull/718
$ git checkout pull/718

Update a local copy of the PR:
$ git checkout pull/718
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/718/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 718

View PR using the GUI difftool:
$ git pr show -t 718

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/718.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Aug 11, 2026

Copy link
Copy Markdown

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Aug 11, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport 01a9a4021848aabc4bb68600a89a380a76a33ff1 8387721: C2: Print Node barrier data Aug 11, 2026
@openjdk

openjdk Bot commented Aug 11, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Aug 11, 2026
@mlbridge

mlbridge Bot commented Aug 11, 2026

Copy link
Copy Markdown

Webrevs

@phohensee phohensee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

25u's dump_adr_type doesn't use it's mem argument: I guess that got cleaned up somewhere else.

@openjdk

openjdk Bot commented Aug 18, 2026

Copy link
Copy Markdown

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@shipilev

Copy link
Copy Markdown
Member Author

/approval request Improves compiler-side diagnostics with Late Barrier Expansion GCs (ZGC and G1 in JDK 25u). Small patch, but requires minor adaptations. Testing passes. Risk is on lower side: compiler diagnostic code, non-product code, no customer exposure.

@openjdk

openjdk Bot commented Aug 20, 2026

Copy link
Copy Markdown

@shipilev
8387721: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants