8390917: NullPointerException test fails with new message

[coleenp]

Please review this small test fix. The C1 compiler doesn't resolve the field in the cpCache so the new NPE message hedges to say that the field could have been a null restricted field, and adds that to the error message.
This doesn't fail on aarch64 because c1 patching will deoptimize the error reporting method testFailedAction, and then resolved the cpCache for the field. X86 doesn't do this so the test needs the addition of the new message for this case.
This is only if you run with -Xcomp which is an atypical way for customers to run.
Tested with the new test 100x.

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8390917: NullPointerException test fails with new message (Bug - P4)

Reviewers

• Johan Sjölen (@johan-sjolen - Reviewer)
• Frederic Parain (@fparain - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32493/head:pull/32493
$ git checkout pull/32493

Update a local copy of the PR:
$ git checkout pull/32493
$ git pull https://git.openjdk.org/jdk.git pull/32493/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 32493

View PR using the GUI difftool:
$ git pr show -t 32493

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32493.diff

Using Webrev

Link to Webrev Comment

[coleenp]

I forgot to mention that I added this to the checkMessage method, rather than the 16 places that check for "Cannot assign field".

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8390917: NullPointerException test fails with new message

Reviewed-by: jsjolen, fparain

You can use pull request commands such as /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

• 8158dfe: 8390550: C2 hit MemLimit when run with -Xcomp -XX:VerifyIterativeGVN=1110
• 60c4ae6: 8390914: [leyden] add missing relocations for addresses recorded in AOT code cache
• fd943b7: 8390824: ProblemList container tests intolerant of non-writable /tmp
• ... and 15 more: https://git.openjdk.org/jdk/compare/3e3b06dbb07cc74076d1674dd2abc5540d600d3c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-runtime. This can be overridden with the /reviewers command.

[mlbridge]

Webrevs

• 00: Full (76978365)

[coleenp]

Thank you Johan and Fred. Since it's a test and causing some noise in CI, i'm integrating now.
/integrate

[openjdk]

Going to push as commit 372ce08.
Since your change was applied there have been 18 commits pushed to the master branch:

• 8158dfe: 8390550: C2 hit MemLimit when run with -Xcomp -XX:VerifyIterativeGVN=1110
• 60c4ae6: 8390914: [leyden] add missing relocations for addresses recorded in AOT code cache
• fd943b7: 8390824: ProblemList container tests intolerant of non-writable /tmp
• ... and 15 more: https://git.openjdk.org/jdk/compare/3e3b06dbb07cc74076d1674dd2abc5540d600d3c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit 372ce08.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.