Skip to content

8390874: MethodData::extra_data_lock memory leak - #32492

Open
synecdoche wants to merge 1 commit into
openjdk:masterfrom
synecdoche:openjdk/JDK-8390874
Open

8390874: MethodData::extra_data_lock memory leak#32492
synecdoche wants to merge 1 commit into
openjdk:masterfrom
synecdoche:openjdk/JDK-8390874

Conversation

@synecdoche

@synecdoche synecdoche commented Aug 23, 2026

Copy link
Copy Markdown


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8390874: MethodData::extra_data_lock memory leak (Bug - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32492/head:pull/32492
$ git checkout pull/32492

Update a local copy of the PR:
$ git checkout pull/32492
$ git pull https://git.openjdk.org/jdk.git pull/32492/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 32492

View PR using the GUI difftool:
$ git pr show -t 32492

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32492.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Aug 23, 2026

Copy link
Copy Markdown

👋 Welcome back synecdoche! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Aug 23, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the hotspot hotspot-dev@openjdk.org label Aug 23, 2026
@openjdk

openjdk Bot commented Aug 23, 2026

Copy link
Copy Markdown

@synecdoche The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk

openjdk Bot commented Aug 23, 2026

Copy link
Copy Markdown

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot. This can be overridden with the /reviewers command.

@synecdoche
synecdoche force-pushed the openjdk/JDK-8390874 branch 3 times, most recently from 5630936 to 857c65d Compare August 24, 2026 19:18
@synecdoche synecdoche changed the title delete _extra_data_lock in MethodData::release_C_heap_structures 8390874: MethodData::extra_data_lock memory leak Aug 24, 2026
@shipilev

Copy link
Copy Markdown
Member

The test is obviously too slow, GHA times out everywhere. A better version:
TestMethodDataObjectMutexLeak.java. Bugs out at epoch 6-7 when bug is present. Passes in <20s in both fastdebug and release when bug is fixed.

@synecdoche
synecdoche force-pushed the openjdk/JDK-8390874 branch 3 times, most recently from 574cd53 to 4a01dbb Compare August 25, 2026 16:07
@synecdoche
synecdoche force-pushed the openjdk/JDK-8390874 branch from 4a01dbb to d3014c8 Compare August 25, 2026 16:09
@synecdoche
synecdoche marked this pull request as ready for review August 25, 2026 17:54
@openjdk openjdk Bot added the rfr Pull request is ready for review label Aug 25, 2026
@mlbridge

mlbridge Bot commented Aug 25, 2026

Copy link
Copy Markdown

Webrevs

@synecdoche

Copy link
Copy Markdown
Author

The test is obviously too slow, GHA times out everywhere. A better version: TestMethodDataObjectMutexLeak.java. Bugs out at epoch 6-7 when bug is present. Passes in <20s in both fastdebug and release when bug is fixed.

Right, of course! More methods, more leaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants