8366417: Use InstanceKlass instead of Klass in jfieldIDWorkaround

[coleenp]

Please review this small change to make some parameters InstanceKlass in jfieldIDWorkaround.hpp methods. Some are not changed to InstanceKlass because they're generally called with obj->klass() which would require another InstnaceKlass::cast() to call them.
Tested with tier1-4.

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8366417: Use InstanceKlass instead of Klass in jfieldIDWorkaround (Enhancement - P4)

Reviewers

• Johan Sjölen (@johan-sjolen - Reviewer)
• Ioi Lam (@iklam - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32484/head:pull/32484
$ git checkout pull/32484

Update a local copy of the PR:
$ git checkout pull/32484
$ git pull https://git.openjdk.org/jdk.git pull/32484/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 32484

View PR using the GUI difftool:
$ git pr show -t 32484

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32484.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366417: Use InstanceKlass instead of Klass in jfieldIDWorkaround

Reviewed-by: jsjolen, iklam

You can use pull request commands such as /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 45 new commits pushed to the master branch:

• 372ce08: 8390917: NullPointerException test fails with new message
• 8158dfe: 8390550: C2 hit MemLimit when run with -Xcomp -XX:VerifyIterativeGVN=1110
• 60c4ae6: 8390914: [leyden] add missing relocations for addresses recorded in AOT code cache
• ... and 42 more: https://git.openjdk.org/jdk/compare/09868aaf95a1ea0dc7af623effc04246c7ed1c94...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot. This can be overridden with the /reviewers command.

[mlbridge]

Webrevs

• 01: Full - Incremental (79f1b3c0)
• 00: Full (f88ad1f6)

[johan-sjolen]

LGTM!

[coleenp]

Thanks Johan.

[coleenp]

Thanks for reviewing and offline suggestions, Ioi.
/integrate

[openjdk]

Going to push as commit 0cec602.
Since your change was applied there have been 45 commits pushed to the master branch:

• 372ce08: 8390917: NullPointerException test fails with new message
• 8158dfe: 8390550: C2 hit MemLimit when run with -Xcomp -XX:VerifyIterativeGVN=1110
• 60c4ae6: 8390914: [leyden] add missing relocations for addresses recorded in AOT code cache
• ... and 42 more: https://git.openjdk.org/jdk/compare/09868aaf95a1ea0dc7af623effc04246c7ed1c94...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit 0cec602.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.