8357381: C2: assert(false) failed: should not be here

[TobiHartmann]

This is a clone of #31037, finishing the integration for @sarannat.

Incremental changes:

• Switching from GrowableArray to Unique_Node_List for orig_phis which was changed in the meantime by JDK-8358560.
• Addressed @merykitty's review comments: Replaced is_mem_read_only_string_intrinsic by the new is_memory_access_intrinsic.
• Removed -XX:CompileThreshold=1000 and duplicate @runs from the test. Added warmup and increased iterations to make it more robust. I also added a run without flags.

Thanks,
Tobias

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8357381: C2: assert(false) failed: should not be here (Bug - P3)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Quan Anh Mai (@merykitty - Reviewer)

Contributors

• Saranya Natarajan <snatarajan@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32467/head:pull/32467
$ git checkout pull/32467

Update a local copy of the PR:
$ git checkout pull/32467
$ git pull https://git.openjdk.org/jdk.git pull/32467/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 32467

View PR using the GUI difftool:
$ git pr show -t 32467

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32467.diff

Using Webrev

Link to Webrev Comment

[TobiHartmann]

/contributor add @sarannat

[bridgekeeper]

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357381: C2: assert(false) failed: should not be here

Co-authored-by: Saranya Natarajan <snatarajan@openjdk.org>
Reviewed-by: kvn, qamai

You can use pull request commands such as /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 50 new commits pushed to the master branch:

• 5ad2eb8: 8389110: java/nio/file/FileStore/Basic.java testEnumerateFileStores fails in container: FileStores should be unique
• 4849063: 8359208: Remove runtime/signal/TestSigstop.java since it is always skipped
• c52c076: 8390309: Remove deprecated comment() method from nsk.share.Log
• ... and 47 more: https://git.openjdk.org/jdk/compare/90f142d65372d2d0f0460b790404dda297336972...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@TobiHartmann
Contributor Saranya Natarajan <snatarajan@openjdk.org> successfully added.

[openjdk]

@TobiHartmann The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-compiler. This can be overridden with the /reviewers command.

[mlbridge]

Webrevs

• 00: Full (d5a0ac3f)

[vnkozlov]

Looks good. thank you for picking it up.

[merykitty]

Is there any reason why a memory_access_intrinsic is handled differently from a MemNode?

[TobiHartmann]

As far as I know, there is no semantic difference. This is basically the "meat" of the original fix proposed in #31037: MemNodes are already processed through the memnode_worklist, while memory-access intrinsics are not MemNodes and do not go through that path. Therefore, when Ideal() exposes a direct memory edge, move_inst_mem() repairs it here.

Unifying the two paths might be cleaner, but would require more invasive changes.

[merykitty]

Thanks, that sounds reasonable.

[TobiHartmann]

Thanks Quan-Anh!

[TobiHartmann]

/integrate

[openjdk]

Going to push as commit a7977b8.
Since your change was applied there have been 58 commits pushed to the master branch:

• 1929061: 8390650: Unsafe access with constant zero offset triggers assert in EA
• d1562ff: 8370914: C2: Reimplement Type::meet and Type::join
• 921ea73: 8390614: RISC-V: Support VerifyOops for AOT caching stub and code
• ... and 55 more: https://git.openjdk.org/jdk/compare/90f142d65372d2d0f0460b790404dda297336972...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TobiHartmann Pushed as commit a7977b8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.