Add Microsoft Edge browser constants and deny list support - #1160
Open
subhra-io wants to merge 2 commits into
Open
Add Microsoft Edge browser constants and deny list support#1160subhra-io wants to merge 2 commits into
subhra-io wants to merge 2 commits into
Conversation
Adds Browsers.Edge with package name, verified signature hash, and custom tab minimum version. Adds EDGE_CUSTOM_TAB and EDGE_BROWSER matchers to VersionedBrowserMatcher. This enables developers to exclude Edge from the authorization flow using BrowserDenyList, working around the 'Stay in Microsoft Edge' redirect interception issue on Android. Includes unit tests and README documentation with usage examples. Fixes openid#1151
A small test app that: - Lists all installed browsers with their SHA-512 signature hashes - Extracts the Edge signing certificate hash for Browsers.Edge - Verifies the BrowserDenyList correctly excludes Edge This module is intended for development/testing only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds
Browsers.Edgeconstants andVersionedBrowserMatcher.EDGE_CUSTOM_TAB/EDGE_BROWSERmatchers, enabling developers to exclude Microsoft Edge from the authorization flow.This addresses #1151 — Edge on Android intercepts the redirect URI callback and shows a "Stay in Microsoft Edge" prompt, which can leave users stuck on the login page.
Changes:
Browsers.java— AddedBrowsers.Edgeinner class with the verified package name (com.microsoft.emmx), SHA-512 signature hash, and custom tab minimum version.VersionedBrowserMatcher.java— AddedEDGE_CUSTOM_TABandEDGE_BROWSERstatic matchers.EdgeBrowserTest.java— Added 16 unit tests covering constants, matchers, deny list, and allow list scenarios.README.md— Documented the workaround with code examples.edgetest/— Added an optional device test app for verifying the fix on real hardware.Usage: