Repository navigation
Require --env-url in the Wordle GRPO script - #1537
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3158933. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Each GRPO step opens 64 sessions, and
openenv/wordleallows 8 (MAX_CONCURRENT_ENVS). With the official Space as the default, a run without--env-urlfails partway into the first step. Nowgrpo.pyrequires--env-url, so it fails at startup, and the README and tutorial already say to pass the URL of your copy.evaluate.pykeeps its default, since it plays one game at a time. Both scripts now callget_token()once.Same change as in the TRL Wordle example (huggingface/trl#7932).
Note
Low Risk
CLI and test-only changes for the Wordle example scripts; no changes to auth logic beyond avoiding a duplicate token lookup.
Overview
GRPO training now requires
--env-urlat startup (no default to the publicopenenv-wordleSpace). That avoids a mid-step failure when a run opens many concurrent sessions against a Space capped at 8 environments while GRPO needs 64.evaluate.pystill defaults--env-urlfor single-game runs.evaluate.pyandgrpo.pyboth callget_token()once when building optional auth headers for private Spaces.Tests pass
--env-urlwhen exercisinggrpo.py.Reviewed by Cursor Bugbot for commit 4c8463d. Bugbot is set up for automated code reviews on this repo. Configure here.