fix: round the displayed problem score to two decimal places - #298
fix: round the displayed problem score to two decimal places#298Agrendalath wants to merge 1 commit into
Conversation
This matches the answer notification message format.
|
Thanks for the pull request, @Agrendalath! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
When a problem's weight doesn't divide evenly among its questions, the weighted score is a repeating fraction and is rendered in full. I.e., the learners see
0.3333333333333333/1.0 point. However, the notification that appears when learners submit the answer is already rounded to two decimal places. This PR changes the main score message to match this behavior.Before
After
Testing instructions
Create the following Problem XBlock and test how the grade is displayed:
Author's notes
str(progress.frac()) if progress else (0, 0), but using the logic from the__str__method felt somewhat hacky.total, as changing1.0to1in this line could be considered a refactor that requires a product decision, instead of being a simple fix.