Repository navigation
Add IsVirtual to KNE solver devices - #158
Open
navaneethyv wants to merge 1 commit into
Open
navaneethyv wants to merge 1 commit into
navaneethyv wants to merge 1 commit into
Conversation
Every KNE binding embeds *solver.ServiceDUT, so this exposes "the device is emulated" to test frameworks via an optional interface (interface{ IsVirtual() bool }) on the binding DUT, without changing the binding.DUT interface. Hardware bindings do not implement it.
Motivation: openconfig/featureprofiles tests need to scale traffic rates and similar parameters on KNE without matching dut.Model() against image names, which is unreliable because KNE reports the topology model string (e.g. "8201", "ixr10e") that can be identical to real hardware.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
IsVirtual() booltosolver.ServiceDUTandsolver.ServiceATE, both returning true, with focused unit coverage. This lets test frameworks detect emulated KNE devices through an optional interface without changingbinding.DUT.KNE model strings can match real hardware models, so model-based detection is unreliable when scaling traffic rates and similar test parameters.