Repository navigation
Update ports.go to update port list once for all ports instead of calling update port list for every port - #790
Open
gavinz-ship-it wants to merge 3 commits into
Open
gavinz-ship-it wants to merge 3 commits into
gavinz-ship-it wants to merge 3 commits into
Conversation
Avoid calling updatePortList repeatly for each port.
Update to call CreatePorts instead of CreatePort
Contributor
|
/gcbrun |
Contributor
Author
|
Started a workflow run: https://fusion2.corp.google.com/6cb8f8b3-2038-4d56-8eab-64acba96d481 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the original code, each interface calls updatePortList once. This pull request reduce the number of calls to updatePortList so that it is called once for all prots.
In the original code, updatePortList perform linear number of operations. So CreatePorts performs quadratic number of operations.
In the new code, updatePortList is called only once so CreatePorts performs linear number of operations and 2 grpc call for updatePortList.