Repository navigation
Refactor CreatePort - #789
Merged
Merged
Conversation
Contributor
|
/gcbrun |
sonikajindal
reviewed
Nov 6, 2026
sonikajindal
reviewed
Nov 6, 2026
sonikajindal
reviewed
Nov 6, 2026
Contributor
|
Overall the refactor looks good, jetski pointed out a few readability and nits I posted |
Update names
Do not perform port update statement for dummy ports.
Contributor
|
/gcbrun |
sonikajindal
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I find the code of CreatePort very hard to read so I refactored it a little bit. Specifically I created some helper functions storeAttributes, storeSwitchAttribute, getSgs, getQueues.
After the change, the main logic of CreatePort is shorter and easier to read.