Repository navigation
Conversation
- TE-11.2, TE-11.21: reduce traffic rate to 10k pps for SRL containers.
- TE-2.1: add WaitForARP after StartProtocols in createTrafficFlows,
- TE-3.5: use gnmi.Watch/Await for AFT ipv4-entry telemetry checks.
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces several stability and reliability improvements for gRIBI tests running on KNE. The changes primarily focus on adjusting traffic parameters, ensuring proper ARP resolution before traffic flow, and enhancing telemetry verification mechanisms to handle asynchronous state updates more effectively. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #6030 / e2c16c4Virtual Devices
Hardware Devices
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reduces the traffic frames per second (fps) in backup NHG tests, adds mandatory WaitForARP calls in ipv4_entry_test.go to ensure neighbor resolution, and replaces static gnmi.Get calls with gnmi.Watch in ordering_ack_test.go to monitor IPv4 entry states. The reviewer recommended replacing the hardcoded time.Minute timeout in the new gnmi.Watch calls with the package-level awaitDuration constant to prevent test flakiness in slow virtual environments.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
/fptest virtual |
| vrf1 = "TE_VRF_111" | ||
| vrf2 = "vrfB" | ||
| fps = 1000000 // traffic frames per second | ||
| switchovertime = 250.0 // switchovertime during interface shut in milliseconds |
There was a problem hiding this comment.
Seems like a generic change, how do you ensure that this is only specific to KNE . This changes the default behavior for hw too.
There was a problem hiding this comment.
@snaragund while not elegant , the way things have been done in the past Is
featureprofiles/feature/sflow/otg_tests/sflow_base_test/sflow_base_test.go
Lines 287 to 298 in 4b58f8b
Can you follow this pattern so that it doesn't;t break over all ?
There was a problem hiding this comment.
Agreed FPS changes in TE-11.2 & TE-11.21 both can be gated with IsKNEBinding method used in #6149 but intent of both tests README were not altered/dependent based on fps rate. Also verified by executing both tests on Hw it passed. If you would suggest to use IsKNEBinding method?
|
@snaragund looks good over all, concerned about the change of FPS that will reduce the effectiveness for tests on actual HW platforms. How do we limit the blast radius ? |
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."