Repository navigation
Implement StopContainerRequest.restart - #94
Merged
Merged
Conversation
The gNOI containerz spec defines StopContainerRequest.restart: "If restart is set, the target should start the container immediately after stopping it." The server ignored the field, so a restart request only stopped the container. - containers: add options.Restart(). - server: pass options.Restart() to the manager when restart is set. - containers/docker: when Restart is set, call docker ContainerRestart with the same StopOptions timeout that ContainerStop uses. The container keeps its ID, configuration and restart policy. Behaviour without restart is unchanged. - client: StopContainer takes optional StopOptions; WithRestart() sets restart. Existing callers are unchanged. - cmd: add --restart to `containerz container stop`.
f-sommerauer
marked this pull request as ready for review
November 5, 2026 15:18
alshabib
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gNOI containerz spec defines StopContainerRequest.restart: "If restart
is set, the target should start the container immediately after stopping
it." The server ignored the field, so a restart request only stopped the
container.
with the same StopOptions timeout that ContainerStop uses. The container
keeps its ID, configuration and restart policy. Behaviour without
restart is unchanged.
restart. Existing callers are unchanged.
containerz container stop.