Skip to content

fix: drop user.openvfs.data written by processes other than the desktop client #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
flash7777 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: drop user.openvfs.data written by processes other than the desktop client #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/openvfsfuse/openvfsfuse.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,6 +703,19 @@ static int openVFSfuse_fsync(const char *orig_path, int isdatasync, struct fuse_
static int openVFSfuse_setxattr(const char *orig_path, const char *name, const char *value, size_t size, int flags)
{
const auto path = getInternalPath(orig_path);

// File managers copy all user.* xattrs on copy and paste. A copied
// user.openvfs.data would carry the fileid and state of the original, so
// only the desktop client may write it. Other writers drop the entry, the
// client sets it again for files inside the sync root.
const auto desktopClientPid = _jobs.desktopClientPid();
if (std::string_view(name) == OpenVFS::Constants::XAttributeNames::Data && desktopClientPid > 0
&& !callerBelongsToProcess(fuse_get_context()->pid, desktopClientPid)) {
openvfsfuse_log(path, "setxattr", 0, "dropped %s written by pid %d", name, fuse_get_context()->pid);
Xattr::removexattr(path, name);
return 0;
}

return Xattr::setxattr(path, name, value, size, flags);
}

Expand Down
Loading