Repository navigation
feat: make terminal renderer integration optional - #151
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
vincentkoc
marked this pull request as ready for review
November 3, 2026 13:02
vincentkoc
force-pushed
the
feat/adoption-compatibility-20261103
branch
from
November 3, 2026 13:03
5d30908 to
d22e3c5
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stream/protocol consumers currently install Ghostty even when they keep another renderer. Make
ghostty-web@0.4.0an optional peer, expose the existingattachTerminalStreamthrough/stream, and retain its/browserexport.Add an executable xterm example and Chromium test, strict TypeScript and Vite checks of an installed renderer-free consumer, and per-entry gzip measurements. Runtime TypeScript grows by seven lines; the attachment implementation is moved, not duplicated.
Compatibility And Security
Ghostty renderer and Node asset-serving consumers must explicitly install
ghostty-web@0.4.0. The synchronous/worker-assetsexport stays self-contained to preserve its existing contract; extracting it remains a coordinated breaking-release decision. No protocol, event ordering, cancellation or authorization change. No new required runtime dependency.Validation
Final head
d22e3c5b737c058af56097635eb81cbffae2a2ec, rebased ontoc6d0be15c66e5c76c013ee87eb81a0b5198a1e6b. Preserves the current main cancellation, reconnect, protocol, Worker, stdio and fanout fixes.pnpm checkpassed on Node 22/24 across Linux, macOS and Windows, plus Node 26 on Linux.pnpm test:browserpassed all 11 Chromium checks, including xterm ANSI/UTF-8 output, cancellation/disposal and existing Node/Worker Ghostty assets.The production TypeScript delta remains +50/-43 (net +7); test TypeScript is +43/-1. Runtime growth is the structural renderer target and the existing attachment export, not a second implementation.