Repository navigation
fix(node): stop queued input after stdio teardown - #145
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stop queued stdin writes when a stdio attachment ends or fails. Previously, a second chunk could reach the terminal after
attachLocalStdio()had returned and removed its listeners, once an earlier blocked write completed. Mark the attachment as no longer accepting input before cleanup starts. Keep the existing nonblocking treatment of an already-started write and the resize cleanup contract.Replace the custom cleanup fixture with real streams and cover output completion and failure. Production delta: +3 lines, justified by the attachment lifetime boundary.
Validation
23e771cdac2e90840c39f30a36953cede1f52e1e.23e771cdac2e90840c39f30a36953cede1f52e1e. Rebased code and test patches were verified unchanged.