Skip to content

test(stream): verify slow subscriber isolation - #143

Merged
vincentkoc merged 1 commit into
mainfrom
test/libterminal-fanout-coverage-20261103
Nov 3, 2026
Merged

vincentkoc merged 1 commit into
mainfrom
test/libterminal-fanout-coverage-20261103

Conversation

@vincentkoc

@vincentkoc vincentkoc commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

Summary

The slow-subscriber isolation test previously had only a slow subscriber. Add a fast peer and verify continued delivery, its retained subscription, and normal closure after the slow peer overflows.

Remove the redundant 20,000-fragment replay-buffer case while keeping the 100,000-fragment regression. Complete the small test audit ledger with coverage decisions across all eleven unit/integration files and the browser suite.

Compatibility And Security

Tests and ledger only; production LOC delta is zero. No protocol, exports, runtime behavior, or release changes. No demonstrated broken public feature or orphan fixture was found during the audit.

Validation

  • Crabbox AWS Linux, Node 24.19.0: pnpm check passed (166 tests, formatting, build, typecheck, lint, package install/import checks).
  • pnpm test:browser passed all 10 real-browser cases.
  • Rebase onto the merged parent preserved the identical source tree.
  • CI passed: Node 22/24 on Linux, macOS, and Windows; Node 26 on Linux; browser smoke.
  • Independent P0–P3 branch review: no actionable findings.
  • Follows test: remove duplicate WebSocket fixtures and timing races #141 and test(node): exercise the native PTY driver #142; decisions are in TEST_CLEANUP.md.
  • No credentials, private paths, private hosts, or sensitive logs included.

@clawsweeper

clawsweeper Bot commented Nov 3, 2026

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@vincentkoc
vincentkoc marked this pull request as ready for review November 3, 2026 12:31
@vincentkoc
vincentkoc merged commit b6c7276 into main Nov 3, 2026
11 of 12 checks passed
@vincentkoc
vincentkoc deleted the test/libterminal-fanout-coverage-20261103 branch November 3, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant