Repository navigation
build(deps): update phone metadata and CodeQL - #400
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex review: needs maintainer review before merge. What this changesThis PR updates PhoneNumberKit to 5.0.14, refreshes both CodeQL action pins, and records the updates in the changelog. Example: Building imsg with its tracked dependency lock.
Review scores
ProductKind: Maintenance · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep this maintainer-authored PR open: the dependency updates are absent from main, and the focused patch has no actionable correctness or security findings. Priority: P3 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherIMsgCore uses PhoneNumberKit to normalize recipient and contact numbers; the separate CodeQL workflow analyzes repository code and uploads security results. flowchart LR
A[Recipient and contact numbers] --> B[IMsgCore normalizer]
C[PhoneNumberKit metadata] --> B
B --> D[Normalized handles]
E[Repository source] --> F[Pinned CodeQL actions]
F --> G[Security analysis results]
Technical reviewBest possible solution: Land the existing focused dependency refresh through the repository’s normal checks. Do we have a high-confidence way to reproduce the issue? This is a maintenance update rather than a bug report; the old pins on main and replacement release identities are directly verified. Is this the best way to solve the issue? Updating the existing pins is the smallest complete change, and upstream confirms that the PhoneNumberKit update changes metadata rather than implementation or minimum platform requirements. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 30893116d52d. Provenance checked
TestingProof path: in-process harness. SecurityNone. EvidenceWhat I checked:
Likely related people:
Preflight sourceSource unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified. LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed November 14, 2026, 2:38 AM ET / 07:38 UTC. |
Update PhoneNumberKit to 5.0.14 (phone metadata 9.0.43) and refresh both CodeQL steps to the current immutable v4 revision. Keep the Swift 6.1 package minimum, macOS 14 deployment floor, xcode-27 build runners, and documented macOS 26 CodeQL tracing exception.
There are no open Dependabot alerts. The dependency release is from November 6, and no repository cooldown policy blocks it. Validate with the documented Linux gate on Crabbox, exact-head CI, and a release workflow dry run at the existing version after merge. No release, tag, or version bump is requested.
Validation: the complete documented Linux gate passed, including tests, release archive smoke checks, and docs. Independent P2 review is clean. Full macOS/Linux and CodeQL checks run at this PR head.