[thurstonsand]

Tracked sends lowercased caller UUIDs, while Messages' SMS/RCS relay expects Apple's uppercase form. Preserve canonical uppercase UUIDs in both RPC and helper dispatch, with case-insensitive input and duplicate checks.

Refs #390. The focused regression fails on main with three assertions and passes after this change. Six focused tests cover the UUID round trip, collisions, capability rejection, and uncertain-send fallback prevention. No live messages were sent during maintainer verification. Independent Codex review through P2: scoped-clean. Exact-head CI is required before merge.

Thanks @thurstonsand for the diagnosis, fix, and reported RCS evidence.

The first exact-head CI run caught an older helper-envelope fixture still expecting lowercase. Its isolated synthetic executable reproduced that failure; the updated fixture verifies uppercase identity in both the acknowledgment and dispatched object and passes. No live messaging was used.

[clawsweeper]

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

[clawsweeper]

Codex review: needs maintainer review before merge.

What this changes

This PR preserves canonical uppercase UUIDs throughout tracked-message sending and response identities.

Example: Send an RCS message with attempt_id 196ff9d0-c48e-4613-a5db-8af306a69533.

• Before: The lowercase GUID reaches Messages; affected-release examples remain unsent with error 4.
• After: The saved GUID is 196FF9D0-C48E-4613-A5DB-8AF306A69533, and the supplied transcript shows delivered status.

Review scores

Measure	Result	What it means
Overall readiness	🐚 platinum hermit (4/6)	A focused, source-correct repair with shipped-entry-point RCS delivery evidence, matching persisted identity, and reported regression-test failures on base and passes on head.
Proof confidence	🦞 diamond lobster (5/6)	Sufficient (terminal): The updated PR body resolves the previous proof request with redacted output from patched imsg RPC and its helper on macOS 26.5.1: a lowercase caller UUID becomes an uppercase response and saved row, and lowercase status lookup reports delivered RCS with error 0. The demonstrated patched scenario is one RCS contact; SMS-only and patched RCS-group delivery are not demonstrated. Supplied focused test output also shows base failures and head passes.
Patch quality	🐚 platinum hermit (4/6)	No actionable review findings were identified.

Product

Kind: Bug fix · Worth it: Yes · Fix scope: Complete
User problem: Tracked SMS/RCS requests can return success while Messages leaves the outgoing message unsent with error 4.
Reason: The patch repairs a demonstrated failure in an existing sending contract with two focused production edits and no new option or dispatch path.

Merge readiness

✅ Ready for maintainer review

Keep open: current main retains the lowercase conversions behind the reported relay failure, and this PR provides a focused repair with no actionable findings.

Priority: P1
Reviewed head: 40558a5cc5101e651161df9397fb6ed577ff67f8

Before merge

None.

Findings

None.

Agent review details

How this fits together

The JSON-RPC server validates a caller UUID, forwards it through the injected Messages helper into native message construction, and exposes the resulting identity for database status reconciliation.

flowchart LR
 A[RPC caller] --> B[UUID normalization]
 B --> C[History collision check]
 C --> D[Injected helper]
 D --> E[GUID reservation and message construction]
 E --> F[Messages relay]
 F --> G[Messages database]
 G --> H[Status reconciliation]

Loading

Technical review

Best possible solution:

Preserve uppercase UUIDs in both existing normalization owners while retaining case-insensitive reconciliation and duplicate rejection.

Do we have a high-confidence way to reproduce the issue?

Current-main source confirms both lowercase conversions, and the contributor supplies affected-release failures and a controlled uppercase retry comparison; no independent Messages send was run during this read-only review.

Is this the best way to solve the issue?

Removing both conversions is the smallest complete repair for the demonstrated casing failure and preserves the documented caller-owned UUID contract.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 1bc0679663bf.

Provenance checked

• RPC and helper UUID normalization changes intended behavior with a stated reason (268912b: feat(rpc): add caller-owned tracked send IDs #235 added caller-owned UUIDs for exact send-timeout reconciliation, collision rejection, and helper reservation; no lowercase-specific requirement was recorded.)
• Existing tracked-send test expectations changes intended behavior with a stated reason (268912b: The original tests enforced matching normalized identities; this PR changes their canonical case to repair the demonstrated relay failure.)
• Helper feature-fragment placement keeps the original intent (cb58dec: refactor: organize the injected helper into private feature modules #296 moved helper features into private fragments while preserving one compiled translation unit and shared ownership state.)

Testing

Proof path: shipped entry point.

Security

None.

Evidence

What I checked:

• Pinned change: The introduced diff removes two lowercase conversions, updates existing regression assertions, and adds an Unreleased changelog entry. (Sources/imsg/RPCServer+SendHandlers.swift:48, 40558a5cc510)
• Current main still needs the repair: Current main explicitly lowercases the UUID in both the RPC handler and injected helper. (Sources/IMsgHelper/SendMessage.inc:53, 1bc0679663bf)
• Updated live proof resolves the prior blocker: The full PR body supplies a patched macOS 26.5.1 RPC request with a lowercase UUID, uppercase response identities, matching chat.db rows, and delivered RCS status queried using the lowercase UUID; it also supplies base-fail/head-pass test output. (40558a5cc510)
• Affected released workflow: send.tracked never delivers to SMS or RCS chats: lowercased GUIDs stay unsent with error 4 #390 reports imsg 0.21.0 tracked SMS/RCS failures, successful iMessage sends, and successful uppercase retry through Messages.
• Existing-state compatibility: Status reconciliation and the tracked-send history collision check use a case-insensitive database lookup; existing coverage queries a lowercase stored GUID using uppercase input. (Sources/IMsgCore/MessageStore+Messages.swift:355, 40558a5cc510)
• Original contract and hardening: feat(rpc): add caller-owned tracked send IDs #235 introduced both conversions for caller-owned message identity; its body records no lowercase requirement, and steipete's collaborator comment explains case-insensitive history collision rejection and atomic helper reservation. (Sources/imsg/RPCServer+Handlers.swift, 268912be7189)

Likely related people:

• Peter Steinberger: Raw commit cb58dec adds Sources/IMsgHelper/ChatResolution.inc:31 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: cb58dec17663; files: Sources/IMsgHelper/ChatResolution.inc)

Preflight source

Source unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified.

Review metrics

Metric	Value	Why it matters
Production and test scope	Production +2/-2; tests +8/-8; changelog +2	The repair changes the existing normalization assignments without adding production machinery or test scaffolding.

Root-cause cluster

Relationship: fixed_by_candidate
Canonical: #390
Summary: This PR is the explicit fixing candidate for the casing-related relay failure; UUID substitution remains a separate report.

Members:

• canonical: send.tracked never delivers to SMS or RCS chats: lowercased GUIDs stay unsent with error 4 #390 - Its lowercase-GUID failure matches both production conversions changed by this PR.
• adjacent_distinct: send.tracked returns ok, but Messages saves the message under a different GUID #385 - It reports a different UUID being persisted, which casing normalization alone does not establish as fixed.

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

Labels

Label changes:

• add proof: sufficient: Contributor real behavior proof is sufficient.
• add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🦞 diamond lobster and patch quality is 🐚 platinum hermit.
• add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.
• remove status: 📣 needs proof: Current PR status label is status: 👀 ready for maintainer look.
• remove rating: 🧂 unranked krab: Current PR rating is rating: 🐚 platinum hermit, so this older rating label is no longer current.

Label justifications:

• P1: The affected-release report establishes a broken tracked SMS/RCS sending workflow that acknowledges requests while messages remain unsent.
• rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🦞 diamond lobster and patch quality is 🐚 platinum hermit.
• status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.
• proof: sufficient: Contributor real behavior proof is sufficient.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

History

Review history (1 earlier review cycle)

• reviewed 2026-11-07T00:14:22.921Z sha 40558a5 :: needs real behavior proof before merge. :: none

Reviewed November 6, 2026, 10:15 PM ET / November 7, 2026, 03:15 UTC (Revision 2).

[thurstonsand]

@clawsweeper re-review

[clawsweeper]

🦞👀
Exact review queued.

Re-review progress:

• State: Complete
• Detail: The durable review result and its route handoff completed.
• Run: https://github.com/openclaw/clawsweeper/actions/runs/42333253099
• Updated: 2026-11-07T03:16:54.330Z

[steipete]

Reviewed code and fixture proof; exact-head CI is green.