[steipete]

Update PhoneNumberKit from 5.0.12 to the patch release 5.0.13, published October 27, while keeping the existing Swift and macOS minimums. Refresh the README’s Node pin to match CI. The remaining direct dependencies are current.

Validation: SwiftPM resolved the pinned revision; focused macOS fixture tests and the Linux tests, production build, and standalone archive smoke gate passed. Independent P0–P2 review is clean. Dependabot alerts: 0 open.

[clawsweeper]

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-05T07:09:20.245273Z	ce84e86	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[clawsweeper]

Codex review: needs maintainer review before merge.

What this changes

This PR updates PhoneNumberKit to 5.0.13 and corrects the README’s documented Node version.

Example: A contributor follows the README’s development requirements.

• Before: The README specifies Node 26.12.0 while CI uses 26.12.1.
• After: The README specifies Node 26.12.1, matching CI.

Review scores

Measure	Result	What it means
Overall readiness	🦐 gold shrimp (3/6)	Focused, source-verified maintenance with passing platform checks; confidence in changed metadata behavior rests on upstream data and fixture validation.
Proof confidence	🌊 off-meta tidepool	Not applicable: This collaborator-authored maintenance PR is outside the ordinary contributor proof gate; supplied validation covers fixtures, builds, and archive smoke rather than a changed-range normalization demonstration.
Patch quality	🐚 platinum hermit (4/6)	No actionable review findings were identified.

Product

Kind: Maintenance · Worth it: Yes · Fix scope: Complete
User problem: Recipient normalization relies on current phone-number metadata, and contributor documentation should match CI requirements.
Reason: The maintainer-authored direction continues established dependency maintenance without adding options, APIs, or runtime requirements.

Merge readiness

✅ Ready for maintainer review

Keep open: this maintainer-authored dependency update is absent from main, and the reviewed diff introduces no concrete defect.

Priority: P3
Reviewed head: ce84e86736b70a57785983bb38eb46aedb04dd93

Before merge

None.

Findings

None.

Tests

• Missing end-to-end proof: The supplied evidence does not show a shipped CLI normalization scenario using a changed metadata range.

Agent review details

How this fits together

PhoneNumberKit supplies metadata to IMsgCore’s recipient normalizer, which accepts a number and region and returns E.164 text or the unchanged input before message dispatch.

flowchart LR
  A[CLI or RPC recipient] --> B[MessageSender]
  B --> C[PhoneNumberNormalizer]
  D[PhoneNumberKit metadata] --> C
  C --> E[Normalized recipient]
  E --> F[Message dispatch]

Loading

Technical review

Best possible solution:

Land the focused metadata update and matching documentation correction through the repository’s normal checks.

Do we have a high-confidence way to reproduce the issue?

This is dependency maintenance rather than a reported runtime bug; source inspection verifies the version and documentation differences.

Is this the best way to solve the issue?

Updating the existing dependency owner is appropriately scoped; upstream changes only metadata and retains compatible platform requirements.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 70f2b9b79f5e.

Provenance checked

• PhoneNumberKit requirement and lockfile keeps the original intent (1e9cefd: Refresh upstream phone-number metadata while retaining other package pins and platform requirements.)
• README toolchain documentation keeps the original intent (1d2e372: Document the supported build toolchains; the corrected Node version matches existing workflow configuration.)

Testing

Proof path: in-process harness.

Security

None.

Evidence

What I checked:

• Pinned introduction: The introduced diff changes only the PhoneNumberKit requirement and revision, its changelog entry, and the README Node version; main still requires 5.0.12. (Package.swift:15, ce84e86736b7)
• Dependency scope and pin verified: The imported dependency’s 5.0.13 annotated tag resolves to the pinned commit; its comparison with 5.0.12 changes only metadata resources from 9.0.41 to 9.0.42, with no executable source or package-manifest changes. (Sources/PhoneNumberKit/Resources/.metadata-version:1, eae725a2e62e)
• Existing owner and update precedent: Feature history includes earlier normalization resource repairs and repeated dependency updates by steipete; the prior metadata update in build(deps): update phone metadata and Node setup #341 preserves the same dependency boundary. (Package.swift:15, 1e9cefd898bb)
• Validation and discussion: The complete body reports focused macOS fixtures and Linux build/archive validation; macOS and Linux checks passed at the reviewed head, while Swift analysis remained in progress. Discussion supplies no additional behavior artifact. (ce84e86736b7)
• Policy and inspection limits: The full root AGENTS.md applies to all changed paths; no maintainer-notes directory or pr-simplify skill exists. Historical searches returned the update trail, but blame and an older commit inspection encountered unavailable promisor blobs; REST evidence independently verified the prior dependency change. (AGENTS.md, 70f2b9b79f5e)

Preflight source

Source unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified.

Labels

Label changes:

• add P3: Routine metadata maintenance and documentation correction with no established urgent user failure.
• add rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
• add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

• P3: Routine metadata maintenance and documentation correction with no established urgent user failure.
• rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
• status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed November 5, 2026, 2:20 AM ET / 07:20 UTC.