Merge pull request #1352 from Arnei/eslint-no-unsafe-assignment

Activate eslint no-unsafe-anything

Author: Arnei

eslint.config.js

@@ -19,12 +19,7 @@ export default [
             "@typescript-eslint/no-explicit-any": "off",
             "@typescript-eslint/no-floating-promises": "off",
             "@typescript-eslint/no-misused-promises": "off",
-            "@typescript-eslint/no-unsafe-argument": "off",
-            "@typescript-eslint/no-unsafe-assignment": "off",
-            "@typescript-eslint/no-unsafe-call": "off",
-            "@typescript-eslint/no-unsafe-member-access": "off",
             "@typescript-eslint/no-unused-vars": "off",
-            "@typescript-eslint/no-unsafe-return": "off",
             "@typescript-eslint/require-await": "off",
         },
     },

src/components/About.tsx

@@ -20,12 +20,13 @@ const About = () => {
 			return `/ui/config/admin-ui/${location.pathname.split("/").pop()}.${language}.html`;
 		};
 
-		axios.get(getURL(i18n.language))
+		// We should be getting HTML from the endpoint
+		axios.get<string>(getURL(i18n.language))
 			.then(response => {
 				setAboutContent(response.data);
 			})
 			.catch(() => {
-				axios.get(getURL(typeof i18n.options.fallbackLng === "string" ? i18n.options.fallbackLng : "en-US"))
+				axios.get<string>(getURL(typeof i18n.options.fallbackLng === "string" ? i18n.options.fallbackLng : "en-US"))
 					.then(response => {
 						setAboutContent(response.data);
 					})

src/components/configuration/partials/wizard/NewThemeWizard.tsx

@@ -99,7 +99,7 @@ const NewThemeWizard = ({
 								setActivePage={setPage}
 								completed={pageCompleted}
 								setCompleted={setPageCompleted}
-								formik={formik}
+								isValid={formik.isValid}
 							/>
 							<div>
 								{steps[page].name === "generalForm" && (

src/components/events/partials/ModalTabsAndPages/EventDetailsSchedulingTab.tsx

@@ -152,7 +152,7 @@ const EventDetailsSchedulingTab = ({
 	};
 
 	// checks validity of the formik form
-	const checkValidity = (formik: FormikProps<any>) => {
+	const checkValidity = (formik: FormikProps<InitialValues>) => {
 		if (
 			formik.dirty &&
 			formik.isValid &&

src/components/events/partials/ModalTabsAndPages/NewAssetUploadPage.tsx

@@ -14,7 +14,7 @@ import ModalContentTable from "../../../shared/modals/ModalContentTable";
  */
 interface RequiredFormProps {
 	sourceMode: string,
-	[key: string]: any,
+	[key: string]: unknown,
 }
 
 const NewAssetUploadPage = <T extends RequiredFormProps>({
@@ -73,11 +73,17 @@ const NewAssetUploadPage = <T extends RequiredFormProps>({
 														type="file"
 														tabIndex={0}
 													/>
-													{formik.values[asset.id] && (
-														<span className="ui-helper">
-															{formik.values[asset.id].name.substr(0, 50)}
-														</span>
-													)}
+													{(() => {
+														const val = formik.values[asset.id];
+														if (val instanceof File) {
+															return (
+																<span className="ui-helper">
+																	{val.name.substring(0, 50)}
+																</span>
+															);
+														}
+														return null;
+													})()}
 												</div>
 											</td>
 											{/*Button to remove asset*/}

src/components/events/partials/modals/DeleteEventsModal.tsx

@@ -114,8 +114,7 @@ const DeleteEventsModal = ({
 											<td>{isEvent(event) && event.title}</td>
 											<td>
 												{/* Repeat for each presenter*/}
-{/* @ts-expect-error TS(7006): Parameter 'presenter' implicitly has an 'any' type... Remove this comment to see the full error message */}
-												{event.presenters.map((presenter, key) => (
+												{isEvent(event) && event.presenters.map((presenter, key) => (
 													<span className="metadata-entry" key={key}>
 														{presenter}
 													</span>

src/components/events/partials/modals/DeleteSeriesModal.tsx

@@ -192,8 +192,7 @@ const DeleteSeriesModal = ({
 											<td>{isSeries(series) && series.title}</td>
 											<td>
 												{/*Repeat for each creator*/}
-{/* @ts-expect-error TS(7006): Parameter 'organizer' implicitly has an 'any' type */}
-												{series.organizers.map((organizer, key) => (
+												{isSeries(series) && series.organizers.map((organizer, key) => (
 													<span className="metadata-entry" key={key}>
 														{organizer}
 													</span>

src/components/events/partials/modals/EditScheduledEventsModal.tsx

@@ -142,7 +142,7 @@ const EditScheduledEventsModal = ({
 								setActivePage={setPage}
 								completed={pageCompleted}
 								setCompleted={setPageCompleted}
-								formik={formik}
+								isValid={formik.isValid}
 							/>
 							<div>
 								{steps[page].name === "general" && (

src/components/events/partials/modals/StartTaskModal.tsx

@@ -108,7 +108,7 @@ const StartTaskModal = ({
 								setActivePage={setPage}
 								completed={pageCompleted}
 								setCompleted={setPageCompleted}
-								formik={formik}
+								isValid={formik.isValid}
 							/>
 							<div>
 								{steps[page].name === "general" && (

src/components/events/partials/wizards/NewEventSummary.tsx

@@ -16,6 +16,7 @@ import { TransformedAcl } from "../../../../slices/aclDetailsSlice";
 import { renderValidDate } from "../../../../utils/dateUtils";
 import { ParseKeys } from "i18next";
 import ModalContentTable from "../../../shared/modals/ModalContentTable";
+import { UploadAssetsTrack } from "../../../../slices/eventSlice";
 
 /**
  * This component renders the summary page for new events in the new event wizard.
@@ -37,6 +38,7 @@ interface RequiredFormProps {
 	deviceInputs?: string[]
 	configuration: { [key: string]: string }
 	policies: TransformedAcl[]
+	uploadAssetsTrack?: UploadAssetsTrack[]
 	[key: string]: unknown,  // Metadata fields
 }
 
@@ -57,7 +59,7 @@ const NewEventSummary = <T extends RequiredFormProps>({
 	const [uploadAssetsNonTrack, setUploadAssetsNonTrack] = useState<{
 		name: string,
 		translate?: string,
-		value: any,
+		value: File,
 	}[]>([]);
 
 	const uploadAssetOptions = useAppSelector(state => getAssetUploadOptions(state));
@@ -70,10 +72,10 @@ const NewEventSummary = <T extends RequiredFormProps>({
 		const uploadAssetsNonTrack: {
 			name: string,
 			translate?: string,
-			value: any,
+			value: File,
 		}[] = [];
 		for (let i = 0; uploadAssetOptions.length > i; i++) {
-			const fieldValue = formik.values[uploadAssetOptions[i].id];
+			const fieldValue = formik.values[uploadAssetOptions[i].id] as File;
 			if (fieldValue) {
 				const displayOverride = uploadAssetOptions[i].displayOverride as ParseKeys;
 				setUploadAssetsNonTrack(uploadAssetsNonTrack.concat({
@@ -155,8 +157,7 @@ const NewEventSummary = <T extends RequiredFormProps>({
 							<table className="main-tbl">
 								<tbody>
 									{/*Insert row for each upload asset of type track user has provided*/}
-{/* @ts-expect-error TS(7006): Parameter 'asset' implicitly has an 'any' type. */}
-									{formik.values.uploadAssetsTrack.map((asset, key) =>
+									{formik.values.uploadAssetsTrack && formik.values.uploadAssetsTrack.map((asset, key) =>
 										asset.file ? (
 											<tr key={key}>
 												<td>