Activate eslint no-unsafe-return

Enable the eslint rule no-unsafe-return

Author: Arnei

eslint.config.js

@@ -20,7 +20,6 @@ export default [
             "@typescript-eslint/no-floating-promises": "off",
             "@typescript-eslint/no-misused-promises": "off",
             "@typescript-eslint/no-unused-vars": "off",
-            "@typescript-eslint/no-unsafe-return": "off",
             "@typescript-eslint/require-await": "off",
         },
     },

src/components/shared/MainNav.tsx

@@ -166,10 +166,12 @@ const MainNav = ({
 	if (firstPathFragment.length > 0) {
 		const arrToSort = linkMap[firstPathFragment as keyof typeof linkMap].links;
 		if (arrToSort != undefined && arrToSort.length > 1) {
-			arrToSort.forEach((item : any) => {
+			arrToSort.forEach(item => {
+				// @ts-expect-error: TODO: Someone else can fix this
 				if (item.path === pathname) { item.tmpIndex = 0; } else { item.tmpIndex = 1; }
 			});
-			arrToSort.sort((a: any, b: any) => a.tmpIndex - b.tmpIndex);
+			// @ts-expect-error: TODO: Someone else can fix this
+			arrToSort.sort((a, b) => a.tmpIndex - b.tmpIndex);
 		}
 	}
 

src/i18n/i18n.ts

@@ -63,6 +63,7 @@ i18n
 					return moment(value).format(format);
 				}
 
+				// eslint-disable-next-line @typescript-eslint/no-unsafe-return
 				return value;
 			},
 		},

src/slices/aclSlice.ts

@@ -14,6 +14,14 @@ import { TransformedAcl } from "./aclDetailsSlice";
 /**
  * This file contains redux reducer for actions affecting the state of acls
  */
+type FetchAcls = {
+	total: AclsState["total"],
+	count: AclsState["count"],
+	limit: AclsState["limit"],
+	offset: AclsState["offset"],
+	results: AclsState["results"],
+};
+
 export type Ace = {
 	action: string,
 	allow: boolean,
@@ -79,7 +87,7 @@ export const fetchAcls = createAppAsyncThunk("acls/fetchAcls", async (_, { getSt
 	// Just make the async request here, and return the response.
 	// This will automatically dispatch a `pending` action first,
 	// and then `fulfilled` or `rejected` actions based on the promise.
-	const res = await axios.get("/admin-ng/acl/acls.json", { params: params });
+	const res = await axios.get<FetchAcls>("/admin-ng/acl/acls.json", { params: params });
 	return res.data;
 });
 
@@ -245,13 +253,7 @@ const aclsSlice = createSlice({
 				state.status = "loading";
 			})
 			// Pass the generated action creators to `.addCase()`
-			.addCase(fetchAcls.fulfilled, (state, action: PayloadAction<{
-				total: AclsState["total"],
-				count: AclsState["count"],
-				limit: AclsState["limit"],
-				offset: AclsState["offset"],
-				results: AclsState["results"],
-			}>) => {
+			.addCase(fetchAcls.fulfilled, (state, action: PayloadAction<FetchAcls>) => {
 				// Same "mutating" update syntax thanks to Immer
 				state.status = "succeeded";
 				const acls = action.payload;

src/slices/eventDetailsSlice.ts

@@ -750,7 +750,7 @@ export const fetchAssetAttachments = createAppAsyncThunk("eventDetails/fetchAsse
 	const params = new URLSearchParams();
 	params.append("id1", "attachment");
 
-	const attachmentsRequest = await axios.get(
+	const attachmentsRequest = await axios.get<EventDetailsState["assetAttachments"]>(
 		`/admin-ng/event/${eventId}/asset/attachment/attachments.json`,
 		{ params },
 	);
@@ -765,7 +765,7 @@ export const fetchAssetAttachmentDetails = createAppAsyncThunk("eventDetails/fet
 	const searchParams = new URLSearchParams();
 	searchParams.append("id1", "attachment");
 
-	const attachmentDetailsRequest = await axios.get(
+	const attachmentDetailsRequest = await axios.get<EventDetailsState["assetAttachmentDetails"]>(
 		`/admin-ng/event/${eventId}/asset/attachment/${attachmentId}.json`,
 		{ params },
 	);
@@ -776,7 +776,7 @@ export const fetchAssetCatalogs = createAppAsyncThunk("eventDetails/fetchAssetCa
 	const params = new URLSearchParams();
 	params.append("id1", "catalog");
 
-	const catalogsRequest = await axios.get(
+	const catalogsRequest = await axios.get<EventDetailsState["assetCatalogs"]>(
 		`/admin-ng/event/${eventId}/asset/catalog/catalogs.json`,
 		{ params },
 	);
@@ -791,7 +791,7 @@ export const fetchAssetCatalogDetails = createAppAsyncThunk("eventDetails/fetchA
 	const searchParams = new URLSearchParams();
 	searchParams.append("id1", "catalog");
 
-	const catalogDetailsRequest = await axios.get(
+	const catalogDetailsRequest = await axios.get<EventDetailsState["assetCatalogDetails"]>(
 		`/admin-ng/event/${eventId}/asset/catalog/${catalogId}.json`,
 		{ params },
 	);
@@ -873,7 +873,7 @@ export const fetchAssetPublications = createAppAsyncThunk("eventDetails/fetchAss
 	const params = new URLSearchParams();
 	params.append("id1", "publication");
 
-	const publicationsRequest = await axios.get(
+	const publicationsRequest = await axios.get<EventDetailsState["assetPublications"]>(
 		`/admin-ng/event/${eventId}/asset/publication/publications.json`,
 		{ params },
 	);
@@ -888,7 +888,7 @@ export const fetchAssetPublicationDetails = createAppAsyncThunk("eventDetails/fe
 	const searchParams = new URLSearchParams();
 	searchParams.append("id1", "publication");
 
-	const publicationDetailsRequest = await axios.get(
+	const publicationDetailsRequest = await axios.get<EventDetailsState["assetPublicationDetails"]>(
 		`/admin-ng/event/${eventId}/asset/publication/${publicationId}.json`,
 		{ params },
 	);
@@ -1351,7 +1351,7 @@ export const fetchWorkflowDetails = createAppAsyncThunk("eventDetails/fetchWorkf
 	workflowId: string
 }) => {
 	const { eventId, workflowId } = params;
-	const data = await axios.get(
+	const data = await axios.get<EventDetailsState["workflows"]["workflow"]>(
 		`/admin-ng/event/${eventId}/workflows/${workflowId}.json`,
 	);
 	return await data.data;
@@ -1501,7 +1501,7 @@ export const fetchWorkflowOperationDetails = createAppAsyncThunk("eventDetails/f
 	operationId?: number
 }) => {
 	const { eventId, workflowId, operationId } = params;
-	const data = await axios.get(
+	const data = await axios.get<EventDetailsState["workflowOperationDetails"]>(
 		`/admin-ng/event/${eventId}/workflows/${workflowId}/operations/${operationId}`,
 	);
 	return await data.data;
@@ -1525,7 +1525,7 @@ export const fetchWorkflowErrorDetails = createAppAsyncThunk("eventDetails/fetch
 	errorId?: number
 }) => {
 	const { eventId, workflowId, errorId } = params;
-	const data = await axios.get(
+	const data = await axios.get<EventDetailsState["workflowErrorDetails"]>(
 		`/admin-ng/event/${eventId}/workflows/${workflowId}/errors/${errorId}.json`,
 	);
 	return await data.data;
@@ -1831,6 +1831,7 @@ export const saveWorkflowConfig = createAppAsyncThunk("eventDetails/saveWorkflow
 	const header = getHttpHeaders();
 	const data = new URLSearchParams();
 	// Scheduler service in Opencast expects values to be strings, so we convert them here
+	// eslint-disable-next-line @typescript-eslint/no-unsafe-return
 	data.append("configuration", JSON.stringify(jsonData, (_k, v) => v && typeof v === "object" ? v : "" + v));
 
 	axios

src/slices/groupSlice.ts

@@ -10,6 +10,14 @@ import { initialFormValuesNewGroup } from "../configs/modalConfig";
 /**
  * This file contains redux reducer for actions affecting the state of groups
  */
+type FetchGroups = {
+	total: GroupState["total"],
+	count: GroupState["count"],
+	limit: GroupState["limit"],
+	offset: GroupState["offset"],
+	results: GroupState["results"],
+};
+
 export type Group = {
 	description: string,
 	id: string,
@@ -54,7 +62,7 @@ export const fetchGroups = createAppAsyncThunk("groups/fetchGroups", async (_, {
 	// Just make the async request here, and return the response.
 	// This will automatically dispatch a `pending` action first,
 	// and then `fulfilled` or `rejected` actions based on the promise.
-	const res = await axios.get("/admin-ng/groups/groups.json", { params: params });
+	const res = await axios.get<FetchGroups>("/admin-ng/groups/groups.json", { params: params });
 	return res.data;
 });
 
@@ -114,13 +122,7 @@ const groupSlice = createSlice({
 			.addCase(fetchGroups.pending, state => {
 				state.status = "loading";
 			})
-			.addCase(fetchGroups.fulfilled, (state, action: PayloadAction<{
-				total: GroupState["total"],
-				count: GroupState["count"],
-				limit: GroupState["limit"],
-				offset: GroupState["offset"],
-				results: GroupState["results"],
-			}>) => {
+			.addCase(fetchGroups.fulfilled, (state, action: PayloadAction<FetchGroups>) => {
 				state.status = "succeeded";
 				const groups = action.payload;
 				state.total = groups.total;

src/slices/jobSlice.ts

@@ -8,6 +8,14 @@ import { createAppAsyncThunk } from "../createAsyncThunkWithTypes";
 /**
  * This file contains redux reducer for actions affecting the state of jobs
  */
+type FetchJobs = {
+	total: JobState["total"],
+	count: JobState["count"],
+	limit: JobState["limit"],
+	offset: JobState["offset"],
+	results: JobState["results"],
+};
+
 export type Job = {
 	creator: string,
 	id: number,
@@ -56,7 +64,7 @@ export const fetchJobs = createAppAsyncThunk("jobs/fetchJobs", async (_, { getSt
 	// This will automatically dispatch a `pending` action first,
 	// and then `fulfilled` or `rejected` actions based on the promise.
 	// /jobs.json?limit=0&offset=0&filter={filter}&sort={sort}
-	const res = await axios.get("/admin-ng/job/jobs.json?", { params: params });
+	const res = await axios.get<FetchJobs>("/admin-ng/job/jobs.json?", { params: params });
 	return res.data;
 });
 
@@ -76,13 +84,7 @@ const jobSlice = createSlice({
 			.addCase(fetchJobs.pending, state => {
 				state.status = "loading";
 			})
-			.addCase(fetchJobs.fulfilled, (state, action: PayloadAction<{
-				total: JobState["total"],
-				count: JobState["count"],
-				limit: JobState["limit"],
-				offset: JobState["offset"],
-				results: JobState["results"],
-			}>) => {
+			.addCase(fetchJobs.fulfilled, (state, action: PayloadAction<FetchJobs>) => {
 				state.status = "succeeded";
 				const jobs = action.payload;
 				state.total = jobs.total;

src/slices/recordingDetailsSlice.ts

@@ -5,6 +5,16 @@ import { createAppAsyncThunk } from "../createAsyncThunkWithTypes";
 /**
  * This file contains redux reducer for actions affecting the state of a recording/capture agent
  */
+type FetchRecordingDetails = {
+	Name: RecordingDetailsState["name"],
+	Status: RecordingDetailsState["status"],
+	Update: RecordingDetailsState["update"],
+	URL: RecordingDetailsState["url"],
+	capabilities: RecordingDetailsState["capabilities"],
+	configuration: RecordingDetailsState["configuration"],
+	inputs: RecordingDetailsState["inputs"],
+}
+
 export interface RecordingDetails {
 	name: string,
 	status: string,
@@ -38,7 +48,7 @@ export const fetchRecordingDetails = createAppAsyncThunk("recordingDetails/fetch
 	// Just make the async request here, and return the response.
 	// This will automatically dispatch a `pending` action first,
 	// and then `fulfilled` or `rejected` actions based on the promise.
-	const res = await axios.get(`/admin-ng/capture-agents/${name}`);
+	const res = await axios.get<FetchRecordingDetails>(`/admin-ng/capture-agents/${name}`);
 	return res.data;
 });
 
@@ -52,15 +62,7 @@ const recordingDetailsSlice = createSlice({
 			.addCase(fetchRecordingDetails.pending, state => {
 				state.statusRecordingDetails = "loading";
 			})
-			.addCase(fetchRecordingDetails.fulfilled, (state, action: PayloadAction<{
-				Name: RecordingDetailsState["name"],
-				Status: RecordingDetailsState["status"],
-				Update: RecordingDetailsState["update"],
-				URL: RecordingDetailsState["url"],
-				capabilities: RecordingDetailsState["capabilities"],
-				configuration: RecordingDetailsState["configuration"],
-				inputs: RecordingDetailsState["inputs"],
-			}>) => {
+			.addCase(fetchRecordingDetails.fulfilled, (state, action: PayloadAction<FetchRecordingDetails>) => {
 				state.statusRecordingDetails = "succeeded";
 				const recordingDetails = action.payload;
 				state.name = recordingDetails.Name;

src/slices/seriesDetailsSlice.ts

@@ -380,7 +380,7 @@ export const updateSeriesTobiraPath = createAppAsyncThunk("series/updateSeriesTo
 	}
 
 	try {
-		const response = await axios.post(`/admin-ng/series/${params.seriesId}/tobira/path`, tobiraParams.toString(), {
+		const response = await axios.post<unknown>(`/admin-ng/series/${params.seriesId}/tobira/path`, tobiraParams.toString(), {
 			headers: {
 				"Content-Type": "application/x-www-form-urlencoded",
 			},
@@ -412,7 +412,7 @@ export const removeSeriesTobiraPath = createAppAsyncThunk("series/removeSeriesTo
 	const path = encodeURIComponent(params.currentPath);
 
 	try {
-		const response = await axios.delete(
+		const response = await axios.delete<unknown>(
 			`/admin-ng/series/${params.seriesId}/tobira/${path}`,
 		);
 

src/slices/seriesSlice.ts

@@ -20,6 +20,14 @@ import { handleTobiraError } from "./shared/tobiraErrors";
 /**
  * This file contains redux reducer for actions affecting the state of series
  */
+type FetchSeries = {
+	total: SeriesState["total"],
+	count: SeriesState["count"],
+	limit: SeriesState["limit"],
+	offset: SeriesState["offset"],
+	results: SeriesState["results"],
+};
+
 export type Series = {
 	contributors: string[],
 	createdBy?: string,
@@ -127,7 +135,7 @@ export const fetchSeries = createAppAsyncThunk("series/fetchSeries", async (_, {
 	// This will automatically dispatch a `pending` action first,
 	// and then `fulfilled` or `rejected` actions based on the promise.
 	// /series.json?sortorganizer={sortorganizer}&sort={sort}&filter={filter}&offset=0&limit=100
-	const res = await axios.get("/admin-ng/series/series.json", { params: params });
+	const res = await axios.get<FetchSeries>("/admin-ng/series/series.json", { params: params });
 	return res.data;
 });
 
@@ -429,13 +437,7 @@ const seriesSlice = createSlice({
 			.addCase(fetchSeries.pending, state => {
 				state.status = "loading";
 			})
-			.addCase(fetchSeries.fulfilled, (state, action: PayloadAction<{
-				total: SeriesState["total"],
-				count: SeriesState["count"],
-				limit: SeriesState["limit"],
-				offset: SeriesState["offset"],
-				results: SeriesState["results"],
-			}>) => {
+			.addCase(fetchSeries.fulfilled, (state, action: PayloadAction<FetchSeries>) => {
 				state.status = "succeeded";
 				const series = action.payload;
 				state.total = series.total;