Activate eslint no-unsafe-call

Enables the eslint rule no-unsafe-call.

Author: Arnei

eslint.config.js

@@ -20,7 +20,6 @@ export default [
             "@typescript-eslint/no-floating-promises": "off",
             "@typescript-eslint/no-misused-promises": "off",
             "@typescript-eslint/no-unsafe-argument": "off",
-            "@typescript-eslint/no-unsafe-call": "off",
             "@typescript-eslint/no-unsafe-member-access": "off",
             "@typescript-eslint/no-unused-vars": "off",
             "@typescript-eslint/no-unsafe-return": "off",

src/components/events/partials/ModalTabsAndPages/EventDetailsSchedulingTab.tsx

@@ -152,7 +152,7 @@ const EventDetailsSchedulingTab = ({
 	};
 
 	// checks validity of the formik form
-	const checkValidity = (formik: FormikProps<any>) => {
+	const checkValidity = (formik: FormikProps<InitialValues>) => {
 		if (
 			formik.dirty &&
 			formik.isValid &&

src/components/events/partials/ModalTabsAndPages/NewAssetUploadPage.tsx

@@ -14,7 +14,7 @@ import ModalContentTable from "../../../shared/modals/ModalContentTable";
  */
 interface RequiredFormProps {
 	sourceMode: string,
-	[key: string]: any,
+	[key: string]: unknown,
 }
 
 const NewAssetUploadPage = <T extends RequiredFormProps>({
@@ -73,11 +73,17 @@ const NewAssetUploadPage = <T extends RequiredFormProps>({
 														type="file"
 														tabIndex={0}
 													/>
-													{formik.values[asset.id] && (
-														<span className="ui-helper">
-															{formik.values[asset.id].name.substr(0, 50)}
-														</span>
-													)}
+													{(() => {
+														const val = formik.values[asset.id];
+														if (val instanceof File) {
+															return (
+																<span className="ui-helper">
+																	{val.name.substring(0, 50)}
+																</span>
+															);
+														}
+														return null;
+													})()}
 												</div>
 											</td>
 											{/*Button to remove asset*/}

src/components/events/partials/modals/DeleteEventsModal.tsx

@@ -114,9 +114,7 @@ const DeleteEventsModal = ({
 											<td>{isEvent(event) && event.title}</td>
 											<td>
 												{/* Repeat for each presenter*/}
-{/* @ts-expect-error TS(7006): Parameter 'presenter' implicitly has an 'any' type... Remove this comment to see the full error message */}
-												{event.presenters.map((presenter, key) => (
-													// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
+												{isEvent(event) && event.presenters.map((presenter, key) => (
 													<span className="metadata-entry" key={key}>
 														{presenter}
 													</span>

src/components/events/partials/modals/DeleteSeriesModal.tsx

@@ -192,9 +192,7 @@ const DeleteSeriesModal = ({
 											<td>{isSeries(series) && series.title}</td>
 											<td>
 												{/*Repeat for each creator*/}
-{/* @ts-expect-error TS(7006): Parameter 'organizer' implicitly has an 'any' type */}
-												{series.organizers.map((organizer, key) => (
-													// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
+												{isSeries(series) && series.organizers.map((organizer, key) => (
 													<span className="metadata-entry" key={key}>
 														{organizer}
 													</span>

src/components/events/partials/wizards/NewEventSummary.tsx

@@ -16,6 +16,7 @@ import { TransformedAcl } from "../../../../slices/aclDetailsSlice";
 import { renderValidDate } from "../../../../utils/dateUtils";
 import { ParseKeys } from "i18next";
 import ModalContentTable from "../../../shared/modals/ModalContentTable";
+import { UploadAssetsTrack } from "../../../../slices/eventSlice";
 
 /**
  * This component renders the summary page for new events in the new event wizard.
@@ -37,6 +38,7 @@ interface RequiredFormProps {
 	deviceInputs?: string[]
 	configuration: { [key: string]: string }
 	policies: TransformedAcl[]
+	uploadAssetsTrack?: UploadAssetsTrack[]
 	[key: string]: unknown,  // Metadata fields
 }
 
@@ -155,10 +157,8 @@ const NewEventSummary = <T extends RequiredFormProps>({
 							<table className="main-tbl">
 								<tbody>
 									{/*Insert row for each upload asset of type track user has provided*/}
-{/* @ts-expect-error TS(7006): Parameter 'asset' implicitly has an 'any' type. */}
-									{formik.values.uploadAssetsTrack.map((asset, key) =>
+									{formik.values.uploadAssetsTrack && formik.values.uploadAssetsTrack.map((asset, key) =>
 										asset.file ? (
-											// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
 											<tr key={key}>
 												<td>
 													{translateOverrideFallback(asset, t, "SHORT")}

src/components/shared/wizard/RenderField.tsx

@@ -40,9 +40,11 @@ const RenderField = ({
 			onClick={() => {
 				if (editableRef.current) {
 					if (editableRef.current.focus) {
+						// eslint-disable-next-line @typescript-eslint/no-unsafe-call
 						editableRef.current.focus();
 					}
 					if (editableRef.current.setFocus) {
+						// eslint-disable-next-line @typescript-eslint/no-unsafe-call
 						editableRef.current.setFocus(); // For DatePicker
 					}
 				}

src/slices/aclSlice.ts

@@ -6,7 +6,7 @@ import { transformToIdValueArray } from "../utils/utils";
 import { NOTIFICATION_CONTEXT_ACCESS } from "../configs/modalConfig";
 import { addNotification, removeNotificationWizardAccess } from "./notificationSlice";
 import { getUserInformation } from "../selectors/userInfoSelectors";
-import { AppDispatch } from "../store";
+import { AppDispatch, RootState } from "../store";
 import { createAppAsyncThunk } from "../createAsyncThunkWithTypes";
 import { initialFormValuesNewAcl } from "../configs/modalConfig";
 import { TransformedAcl } from "./aclDetailsSlice";
@@ -174,8 +174,8 @@ export const deleteAcl = (id: number) => async (dispatch: AppDispatch) => {
 		});
 };
 
-// @ts-expect-error TS(7006):
-export const checkAcls = (acls: TransformedAcl[]) => async (dispatch: AppDispatch, getState) => {
+
+export const checkAcls = (acls: TransformedAcl[]) => async (dispatch: AppDispatch, getState: () => RootState) => {
 	// Remove old notifications of context event-access
 	// Helps to prevent multiple notifications for same problem
 	dispatch(removeNotificationWizardAccess());

src/slices/eventDetailsSlice.ts

@@ -273,9 +273,11 @@ type EventDetailsState = {
 			}[],
 		},
 		video: {
-			previews: {
-				uri: string,
-			}[]
+			video: {
+				previews: {
+					uri: string,
+				}[]
+			},
 			url: string,
 		} | undefined,
 	},
@@ -838,28 +840,29 @@ export const fetchAssetMediaDetails = createAppAsyncThunk("eventDetails/fetchAss
 	const searchParams = new URLSearchParams();
 	searchParams.append("id1", "media");
 
-	const mediaDetailsRequest = await axios.get<EventDetailsState["assetMediaDetails"]>(
+	const mediaDetailsRequest = await axios.get<Omit<EventDetailsState["assetMediaDetails"], "video">>(
 		`/admin-ng/event/${eventId}/asset/media/${mediaId}.json`,
 		{ params },
 	);
 	const mediaDetailsResponse = await mediaDetailsRequest.data;
 
-	let mediaDetails;
+	let mediaDetails: EventDetailsState["assetMediaDetails"];
 
 	if (typeof mediaDetailsResponse === "string") {
 		// TODO: Handle JSON parsing errors
 		// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
 		mediaDetails = JSON.parse(mediaDetailsResponse);
 	} else {
-		mediaDetails = mediaDetailsResponse;
+		mediaDetails = {
+			...mediaDetailsResponse,
+			video: undefined,
+		};
 	}
 
 	mediaDetails.video = {
 		video: {
-			// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
 			previews: [{ uri: mediaDetails.url }],
 		},
-		// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
 		url: mediaDetails.url.split("?")[0],
 	};
 

src/utils/statisticsUtils.ts

@@ -37,6 +37,7 @@ function createXAxisTickCallback(
 
 	return function (tickValue: number | string) {
 		// @ts-expect-error: Typescript does not like "this", but the chart.js documentation insists we should do it this way
+		// eslint-disable-next-line @typescript-eslint/no-unsafe-call
 		return moment(this.getLabelForValue(tickValue)).locale(language).format(formatString);
 	};
 };