Activate eslint no-unsafe-assignment

Enables the eslint no-unsafe-assignment.

Does not fix every problem this rule surfaces, i.e.
unchecked json parses, but it fixes some of them
and therefore at least constitutes some progress.

Author: Arnei

eslint.config.js

@@ -20,7 +20,6 @@ export default [
             "@typescript-eslint/no-floating-promises": "off",
             "@typescript-eslint/no-misused-promises": "off",
             "@typescript-eslint/no-unsafe-argument": "off",
-            "@typescript-eslint/no-unsafe-assignment": "off",
             "@typescript-eslint/no-unsafe-call": "off",
             "@typescript-eslint/no-unsafe-member-access": "off",
             "@typescript-eslint/no-unused-vars": "off",

src/components/events/partials/modals/DeleteEventsModal.tsx

@@ -116,6 +116,7 @@ const DeleteEventsModal = ({
 												{/* Repeat for each presenter*/}
 {/* @ts-expect-error TS(7006): Parameter 'presenter' implicitly has an 'any' type... Remove this comment to see the full error message */}
 												{event.presenters.map((presenter, key) => (
+													// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
 													<span className="metadata-entry" key={key}>
 														{presenter}
 													</span>

src/components/events/partials/modals/DeleteSeriesModal.tsx

@@ -194,6 +194,7 @@ const DeleteSeriesModal = ({
 												{/*Repeat for each creator*/}
 {/* @ts-expect-error TS(7006): Parameter 'organizer' implicitly has an 'any' type */}
 												{series.organizers.map((organizer, key) => (
+													// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
 													<span className="metadata-entry" key={key}>
 														{organizer}
 													</span>

src/components/events/partials/wizards/NewEventSummary.tsx

@@ -158,6 +158,7 @@ const NewEventSummary = <T extends RequiredFormProps>({
 {/* @ts-expect-error TS(7006): Parameter 'asset' implicitly has an 'any' type. */}
 									{formik.values.uploadAssetsTrack.map((asset, key) =>
 										asset.file ? (
+											// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
 											<tr key={key}>
 												<td>
 													{translateOverrideFallback(asset, t, "SHORT")}

src/components/events/partials/wizards/RenderWorkflowConfig.tsx

@@ -124,11 +124,11 @@ const RenderRadio = <T extends RequiredFormProps>(
 };
 
 const RenderNumber = <T extends RequiredFormProps>(
-	{ field, formik } : { field: any, formik: FormikProps<T> }) => {
+	{ field, formik } : { field: FieldSetField, formik: FormikProps<T> }) => {
 	// validate that value of number is between max and min
 	const validate = (value: string) => {
 		let error;
-		if (parseInt(value) > field.max || parseInt(value) < field.min) {
+		if (field.max && field.min && (parseInt(value) > field.max || parseInt(value) < field.min)) {
 			error = "out of range";
 		}
 		return error;

src/components/shared/TimeSeriesStatistics.tsx

@@ -16,7 +16,7 @@ import { useTranslation } from "react-i18next";
 import type { ChartOptions } from "chart.js";
 import { AsyncThunk } from "@reduxjs/toolkit";
 import { useAppDispatch } from "../../store";
-import { DataResolution, TimeMode } from "../../slices/statisticsSlice";
+import { DataResolution, Statistics, TimeMode } from "../../slices/statisticsSlice";
 import { ParseKeys } from "i18next";
 
 
@@ -48,7 +48,7 @@ const TimeSeriesStatistics = ({
 	timeMode: TimeMode,
 	dataResolution: DataResolution,
 	statDescription: string,
-	onChange: AsyncThunk<undefined, { id: string, providerId: string, from: string | Date, to: string | Date, dataResolution: DataResolution, timeMode: TimeMode, }, any>,
+	onChange: AsyncThunk<Statistics[], { id: string, providerId: string, from: string | Date, to: string | Date, dataResolution: DataResolution, timeMode: TimeMode, }, any>,
 	exportUrl: string,
 	exportFileName: (statsTitle: string) => string,
 	totalValue: number,

src/components/shared/modals/ResourceDetailsAccessPolicyTab.tsx

@@ -67,7 +67,7 @@ const ResourceDetailsAccessPolicyTab = ({
 	header: ParseKeys,
 	policies: TransformedAcl[],
 	policyTemplateId: number,
-	fetchHasActiveTransactions?: AsyncThunk<any, string, any>
+	fetchHasActiveTransactions?: AsyncThunk<{ active: boolean }, string, any>
 	fetchAccessPolicies: AsyncThunk<any, string, any>,
 	saveNewAccessPolicies: AsyncThunk<boolean, { id: string, policies: { acl: Acl }, override?: boolean }, any>
 	descriptionText: ParseKeys,

src/components/shared/wizard/RenderField.tsx

@@ -146,7 +146,7 @@ const EditableBooleanValue = ({
 			{...field}
 			ref={ref}
 			type="checkbox"
-			checked={field.value}
+			checked={field.value as boolean}
 			autoFocus={isFirstField}
 		/>
 	);
@@ -214,7 +214,7 @@ const EditableSingleSelect = ({
 	return (
 		<DropDown
 			ref={ref}
-			value={field.value}
+			value={field.value as string}
 			text={text}
 			options={metadataField.collection
 				? metadataField.collection.map(item => ({ label: item.label ?? item.name, value: item.value, order: item.order }))
@@ -299,7 +299,7 @@ const EditableSingleValueTime = ({
 		<div onClick={e => { e.stopPropagation(); }}>
 			<DatePicker
 				ref={ref}
-				selected={typeof field.value === "string" ? parseISO(field.value) : field.value}
+				selected={typeof field.value === "string" ? parseISO(field.value) : field.value as Date}
 				onChange={value => setFieldValue(field.name, value)}
 				showTimeSelect
 				showTimeSelectOnly

src/components/shared/wizard/RenderMultiField.tsx

@@ -29,7 +29,7 @@ const RenderMultiField = ({
 	// Temporary storage for value user currently types in
 	const [inputValue, setInputValue] = useState("");
 
-	const fieldValue = [...field.value];
+	const fieldValue = [...field.value as string[]];
 
 	// Handle change of value user currently types in
 	const handleChange = (e: React.ChangeEvent<HTMLInputElement>) => {

src/components/shared/wizard/SelectContainer.tsx

@@ -8,6 +8,7 @@ import SearchContainer from "../SearchContainer";
 
 type Item = {
 	name: string
+	id?: string
 	[key: string]: unknown
 }
 
@@ -38,7 +39,7 @@ const SelectContainer = ({
 	const [defaultItems, setDefaultItems] = useState<Item[]>([]);
 	// arrays an item can be part of depending on its state
 	const [items, setItems] = useState<Item[]>([]);
-	const [selectedItems, setSelectedItems] = useState(field.value);
+	const [selectedItems, setSelectedItems] = useState<Item[]>(field.value);
 	const [markedForAddition, setMarkedForAddition] = useState<string[]>([]);
 	const [markedForRemoval, setMarkedForRemoval] = useState<string[]>([]);
 
@@ -255,7 +256,6 @@ const SelectContainer = ({
 							onChange={e => handleChangeRemove(e)}
 							value={markedForRemoval}
 						>
-							{/* @ts-expect-error TS(7006): Parameter 'item' implicitly has an 'any' type. */}
 							{selectedItems.map((item, key) => (
 								<option key={key} value={item.name}>
 									{item.name}