Repository navigation
feat(api): expand Live Responses delegation tools - #4233
Conversation
Castiron-Internal-PR: openai/openai-python-internal#385 Castiron-Source-SHA: 2dfcfa8d469453d8aac40be908b9253548bd60a4 Castiron-Public-Base-SHA: 16bdad1
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Approved after static review of b231482. The expanded delegation tools and choices preserve the released function/MCP names and required fields, including non-null MCP name. Creation/update types are consistent; nested shell settings and allowed-tools choices match the transport parsing path. The new offline transport regression covers nested response fields and omitted/null delegation settings. No blocking findings.
No candidate code or tests were run locally. Hosted CI has no reported failures at review time; unfinished checks remain pending.
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed b231482. The added delegation tools and choices match the schema. Existing function/MCP class names and field contracts remain intact, including required, non-null MCP name. Create/update variants agree, and the generated-file hashes match.
The transport regression checks typed session events, nested shell settings, and null/omitted response fields. Hosted build, lint, breaking-change detection and Python 3.14 tests passed. Python 3.10 tests were still running at the last check. Source review only; no local tests, builds, or generation run.
One nonblocking documentation correction is noted inline.
| """The tool choice type. Always `allowed_tools`.""" | ||
|
|
||
|
|
||
| class ToolChoiceFileSearch(BaseModel): |
There was a problem hiding this comment.
[P3] Correct the MCP type description
This field accepts "mcp", but the new docstring says it is always allowed_tools. IDE help now gives callers the wrong discriminator. Please fix the generation input or compiler and regenerate this description in all four delegation modules; it should say mcp.
Expose additional Live Responses delegation tools and tool choices in session creation and updates while preserving the existing Python function and MCP choice types and field contracts. MCP tool-choice
nameremains required and non-null.The MCP tool input currently exposes only
type: "mcp"; server configuration fields are not typed by this change.Validation: 20 focused compatibility and offline transport tests passed, including session creation and update; Ruff and ty passed for the committed transport regression.