Repository navigation
feat(responses): add WebSocket lane overflow isolation - #4225
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
dpiet-oai
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A slow WebSocket lane currently closes the managed session when its event queue fills. Add
isolate_lane_overflow=Trueto the sync and async session constructors. With this option, healthy lanes keep using the same connection. The default remainsFalse.Failed lanes discard queued events and collected response state. Reads keep raising the first buffer error. Their IDs stay reserved until reconnect. The guide explains how the session frees space when its queues fill. It also explains which events become unavailable when the default lane fails. Physical connection failures still end the session. This uses the existing router and reader, without new limits or dependencies.
Validation: all 200 focused session cases pass on Python 3.10/Pydantic 1 and Python 3.13/Pydantic 2. They cover both policies, all queue budgets, eviction, cached finals, default routing, transport failure and reconnect. Pinned Ruff, format and ty checks pass.