Skip to content

fix(api): preserve Responses WebSocket connection behavior - #4221

Merged
markstuart-oai merged 2 commits into
mainfrom
castiron/promotions/pr-389
Nov 1, 2026
Merged

markstuart-oai merged 2 commits into
mainfrom
castiron/promotions/pr-389

Conversation

@markstuart-oai

@markstuart-oai markstuart-oai commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Use the SDK-owned connection helpers for stable and beta Responses WebSockets. This keeps header overrides, connection defaults, cleanup and recovery behavior in place when the clients are regenerated. It removes duplicate connection policy code from both generated resources.

Validation: 617 targeted tests and 10 retained exit tests pass against a fresh, noneditable wheel installation. Two normal generation runs produce identical code. The three SDK-owned test updates are included in this PR.

Castiron-Internal-PR: openai/openai-python-internal#389
Castiron-Source-SHA: be619e819f9bdb9e8904931387f5fed8388cf757
Castiron-Public-Base-SHA: 3622a97
@markstuart-oai
markstuart-oai requested a review from a team as a code owner November 1, 2026 19:55
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-01T19:58:51.531392Z cd9a9db New commits
🔒 Security Review ✅ Completed 2026-11-01T19:59:33.176398Z cd9a9db New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jbeckwith-oai jbeckwith-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed cd9a9db with an independent static pass. No actionable findings. Shared helpers preserve stable/beta sync/async URL and auth preparation, case-insensitive header precedence and removal, connection defaults, retry-budget progress, iterator overrides, and entry/exit exception cleanup. Generated-file hashes match the changed resources.

Hosted checks: {'SUCCESS': 17, 'SKIPPED': 9}. No candidate code or tests executed locally.

@markstuart-oai
markstuart-oai added this pull request to the merge queue Nov 1, 2026
Merged via the queue into main with commit 38075d8 Nov 1, 2026
26 checks passed
@markstuart-oai
markstuart-oai deleted the castiron/promotions/pr-389 branch November 1, 2026 20:43
@openai-sdks openai-sdks Bot mentioned this pull request Nov 1, 2026
gh-actions-shared Bot pushed a commit to xf-qubit/openai-python that referenced this pull request Nov 1, 2026
Automated Release PR
---


##
[3.42.1](openai/openai-python@v3.42.0...v3.42.1)
(2026-11-01)


### Bug Fixes

* **api:** preserve Responses WebSocket connection behavior
([openai#4221](openai#4221))
([38075d8](openai@38075d8))
* **realtime:** validate beta WebSocket authentication profiles
([openai#4218](openai#4218))
([3622a97](openai@3622a97))


### Refactors

* **websocket:** add SDK-owned Responses policy helpers
([openai#4219](openai#4219))
([83ed269](openai@83ed269))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: openai-sdks[bot] <284451331+openai-sdks[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants