Repository navigation
docs: carry generated-file ownership guidance to next - #4196
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jbeckwith-oai
enabled auto-merge (squash)
October 27, 2026 18:39
dpiet-oai
approved these changes
Oct 27, 2026
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ec7430abf8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jbeckwith-oai
added a commit
that referenced
this pull request
Oct 27, 2026
## Summary Correct documentation feedback from #4196, which merged while these fixes were being prepared. Refresh AGENTS.md evidence citations to the credential, redaction, and large-payload rules, and remove the obsolete instruction to submit budget changes as ratchet-only PRs. ## Validation Basic review confirmed only the citation numbers and obsolete sentence changed. Compared every cited AGENTS.md location with the actual rule and ran git diff --check. No runtime or generated-file changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carry the reviewed generated-file ownership guidance from merged #4193 into
next, so contributors follow the simplified generation model before its next regeneration.All four documents exactly match main commit
1b37b9a85e857a7ada4db661bf867bf680290ccf. They replace the retired budget instructions with the rule to change generator inputs/compiler, regenerate owned files, and keep handwritten behavior in separate extensions. Ordinary review enforces ownership; no replacement checker is introduced.This is the handwritten-documentation prerequisite only. Generated tools, inventory, generation metadata, runtime, dependencies, workflows, and release behavior are unchanged; canonical next regeneration will remove the retired generated tools separately.
Validation: basic review, exact byte comparison of all four documents against the merged main commit, four-file scope assertion, and
git diff --checkpass. No runtime tests were rerun for this documentation-only change. SDK CODEOWNER review and normal next CI are required.