Repository navigation
chore(deps-dev): bump griffe from 1.14.0 to 2.3.0 - #4069
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom codeEvaluated main: Trusted main policy: ✅ No new custom-code files detected. 0 mixed files remain; 0 existing customizations changed. Compared A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 40416456978 --repo openai/openai-python \
--name castiron-custom-code-40416456978-1 --dir /tmp/castiron-custom-code-40416456978-1
git apply --stat /tmp/castiron-custom-code-40416456978-1/custom-code.patch
cat /tmp/castiron-custom-code-40416456978-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 06dbb5d019d7b6870b5898bf5df579ca60b61d28 d5b63425ab8366a981673edf380934d77f10c7ca
python3 scripts/castiron/custom_code_report.py report \
--base 06dbb5d019d7b6870b5898bf5df579ca60b61d28 \
--head d5b63425ab8366a981673edf380934d77f10c7ca --target-branch main --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-d5b63425ab83
cat /tmp/castiron-custom-code-d5b63425ab83/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: de69acdec7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| [[package]] | ||
| name = "openai" | ||
| version = "3.29.0" # x-release-please-version | ||
| version = "3.29.0" |
There was a problem hiding this comment.
Restore the release-please version marker
Restore # x-release-please-version on this version line. The dependency-locks job in .github/workflows/ci.yml:63-67 explicitly asserts that uv.lock contains the exact marked line, so every CI run for this commit fails before lint, build, and tests; the same assertion fails locally against the committed lock.
Useful? React with 👍 / 👎.
de69acd to
1269622
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1269622246
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| [[package]] | ||
| name = "griffe" | ||
| version = "1.14.0" | ||
| version = "2.3.0" |
There was a problem hiding this comment.
Raise the declared Griffe security floor
When the dependency-locks job runs the base revision's scripts/check-dependency-security.py before lock validation, this upgrade is compared with the unchanged griffe>=1 declaration in pyproject.toml; running that checker against the parent and this tree exits with Raise the contextual protected security minimum to the patched release for griffe. Update the declared dev-dependency minimum to cover 2.3.0, otherwise CI still fails even after the separately reported release-please marker is restored.
AGENTS.md reference: AGENTS.md:L31-L34
Useful? React with 👍 / 👎.
6611468 to
c7cc4f5
Compare
2e7ffa7 to
f7b046d
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f7b046d11e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -1,5 +1,5 @@ | |||
| version = 1 | |||
| revision = 5 | |||
| revision = 3 | |||
There was a problem hiding this comment.
Regenerate the lockfile with the pinned uv version
After the two previously reported blockers are corrected, the dependency-locks job still runs uv lock --check with uv 0.12.5 (.github/workflows/ci.yml:57-67), while this edit downgrades the lock schema from revision 5 to revision 3 and also strips the root package's locked default-groups metadata. Regenerate the lock with the repository-pinned uv version so the committed file remains current; otherwise that final freshness check reports that uv.lock needs updating.
Useful? React with 👍 / 👎.
8c7770c to
7fcdedc
Compare
Bumps [griffe](https://github.com/mkdocstrings/griffe) from 1.14.0 to 2.3.0. - [Release notes](https://github.com/mkdocstrings/griffe/releases) - [Changelog](https://github.com/mkdocstrings/griffe/blob/main/CHANGELOG.md) - [Commits](mkdocstrings/griffe@1.14.0...2.3.0) --- updated-dependencies: - dependency-name: griffe dependency-version: 2.3.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
7fcdedc to
6f14126
Compare
marcuswood-oai
left a comment
There was a problem hiding this comment.
Reviewed the Griffe development dependency update and restored release-please marker. Focused Griffe compatibility tests and all CI checks pass at d5b6342.
Automated Release PR --- ## [3.40.0](openai/openai-python@v3.39.0...v3.40.0) (2026-10-27) ### Features * **api:** add prompt cache breakpoint TTL options ([openai#4188](openai#4188)) ([3596d18](openai@3596d18)) ### Bug Fixes * **ci:** use an explicit browser demo dependency ([openai#4185](openai#4185)) ([a3f4302](openai@a3f4302)) ### Chores * **api:** record completed generated-code separation ([openai#4190](openai#4190)) ([d7ab5ee](openai@d7ab5ee)) * **deps-dev:** bump griffe from 1.14.0 to 2.3.0 ([openai#4069](openai#4069)) ([766b849](openai@766b849)) * **deps:** bump actions/create-github-app-token from 3.2.0 to 3.3.0 ([openai#4178](openai#4178)) ([06dbb5d](openai@06dbb5d)) * **deps:** bump actions/download-artifact from 8.0.1 to 8.0.2 ([openai#4110](openai#4110)) ([2404d04](openai@2404d04)) * **deps:** bump actions/upload-artifact from 7.0.1 to 7.0.2 ([openai#4107](openai#4107)) ([0adf711](openai@0adf711)) * **deps:** bump github/codeql-action/analyze from 4.38.2 to 4.39.0 ([openai#4177](openai#4177)) ([1e42321](openai@1e42321)) * **deps:** bump openai/codex-action from 1.12 to 1.13 ([openai#4070](openai#4070)) ([904ed3f](openai@904ed3f)) * update generated-code verification and preserve SDK helpers ([openai#4186](openai#4186)) ([9412200](openai@9412200)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: openai-sdks[bot] <284451331+openai-sdks[bot]@users.noreply.github.com>
Bumps griffe from 1.14.0 to 2.3.0.
Release notes
Sourced from griffe's releases.
... (truncated)
Changelog
Sourced from griffe's changelog.
... (truncated)
Commits
ecd5349chore: Prepare release 2.3.009a2a13feat: Add option to give precedence to docstrings in stubs vs. sourcee095a7cfix: Preserve nested tuple parenthesesefa8ac1Merge branch 'main' of github.com:mkdocstrings/griffe092ac31perf: Reuse computed parent inis_imported76e1082chore: Add docs for package parameter8f05a4aperf: Only build debug messages at debug level06cd02eperf: Avoid creating new sets when handling labelse21851eperf: Maintain map of AST node type to visitor functionb968de0perf: Avoid cyclic refs in ASTs to allow garbage-collecting them