Repository navigation
feat(api): support Live Decision tool items - #1308
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6939787e8e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Approved 6939787 after coordinator and independent static review. No actionable findings.
Complete Git tree is identical to the previously reviewed and approved internal candidate https://github.com/openai/openai-java-internal/pull/399 at 70ebc4709c2ecfadb8d9c74e294fd9583bd98592. Coordinator tree-ID comparison and independent recursive blob comparison confirm zero file differences. Reviewed current public feedback and retained the prior static review conclusions.
Hosted CI: {'SUCCESS': 14}. No candidate code or tests executed locally. This is an automated review on Justin’s behalf; it does not constitute a separate human-only review or authorize a merge/release.
6939787 to
f436df7
Compare
markstuart-oai
changed the title
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Approved f436df7 after coordinator and independent static re-review. The complete source tree is identical to the approved internal candidate https://github.com/openai/openai-java-internal/pull/399#pullrequestreview-5709785395 at 4194ac4aa19d7042c27408206c2bd16e3bbdeb43. Matching root tree IDs and independent recursive comparison of all 5,287 entries confirm zero file differences. Existing public feedback and the prior validator compile-blocker fix were checked; no new actionable findings.
Hosted CI is still running (lint, build logic and version support checks passed). Pending CI remains a follow-up. No candidate code or tests executed locally.
Castiron-Internal-PR: openai/openai-java-internal#399 Castiron-Source-SHA: 8e8e9d950ca1901536f698483dbf6caf25831d9d Castiron-Public-Base-SHA: c4ea628
f436df7 to
a0980d6
Compare
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Approved exact head a0980d6 after coordinator and independent static re-review against the previously reviewed commit. Only the exported schema reference and generation statistics changed. Parsed schema values and array ordering are unchanged; all other tree entries match the previously reviewed head.
No actionable findings. Hosted CI is still in progress and remains tracked. No candidate code or tests executed locally.
Live Decision item validation now accepts the supported message roles and tool items. Both existing Item classes keep their builders, getters and serialization. A shared internal validator handles the shared shapes; it does not add new public helper models or builders.
This update is intended for a minor release. Sending an item does not add automatic validation.
Validation passed: clean compilation, 95 focused tests, 1,021 cases through the actual Item methods, and 50 additional-ID cases. Comparison with v4.94.0 source found no previously accepted case lost and no wire changes for those cases; 32 additional supported cases now validate. The repository's official structured-output compatibility check also passes. That check does not cover the entire Live JVM ABI; the targeted Live check additionally compared Item declarations and public signatures against compiled release sources.