Skip to content

Repository navigation

feat(api): add image edit markup overlays - #1305

Merged
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-400
Oct 29, 2026
Merged

feat(api): add image edit markup overlays#1305
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-400

Conversation

@jbeckwith-oai

@jbeckwith-oai jbeckwith-oai commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds an optional markup image to guide image edits.

Changes

  • Provide a transparent PNG markup overlay when editing an image.
  • Document that markup must match the first image dimensions and cannot be combined with a mask.

@jbeckwith-oai
feat(api): add image edit markup overlays
542fe24 
Castiron-Internal-PR: openai/openai-java-internal#400
Castiron-Source-SHA: 7b4f0eb8e67ee74d6b8377d9d58aa32bcb7a705b
Castiron-Public-Base-SHA: 1fc6935
@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner October 29, 2026 14:13
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T14:14:47.758001Z 542fe24 PR opened
🔒 Security Review ✅ Completed 2026-10-29T14:15:39.816720Z 542fe24 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

markstuart-oai
markstuart-oai approved these changes Oct 29, 2026
View reviewed changes

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. markup is carried through the builder overloads, body map, copy, validation, equality and hash paths. InputStream, byte-array and Path inputs reuse the existing multipart machinery and filename handling. Existing parameters and omission behavior are preserved. The additions follow the existing generated model structure and match the inventory.

Full diff and independent source review found no actionable issues. Generated all-parameter fixtures exercise transport, not live PNG validity or mask/markup exclusivity. Hosted CI was still running in the inspected snapshot.

Source-only review: no local SDK tests, builds or generation were run.

Reviewed head: 542fe24326bfe7c15d8889e8e249085c9a0bb4fa; base: 1fc6935fc4a5258cb1910151a06a38ff223b4f33.

@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Oct 29, 2026
Merged via the queue into main with commit aa8cead Oct 29, 2026
14 checks passed
@openai-sdks openai-sdks Bot mentioned this pull request Oct 29, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markstuart-oai markstuart-oai markstuart-oai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jbeckwith-oai @markstuart-oai