Repository navigation
docs: carry generated-file ownership guidance to next - #1288
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e9fbfab9d7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
Approved at 0c9bf38d4ed6f2d3b4857edd4f44504a55e0754a. The three handwritten documents consistently describe generated-file ownership and the legacy strict checker retained on next. The compatibility anchors and shifted citations are correct, and the security model preserves the existing publisher trust boundary. No actionable findings after full source review and an independent pass.
No local tests, builds or generation ran. Live workflow activation and required status settings remain separate from this documentation review.
Summary
Carry the reviewed ownership guidance from #1284 onto next before canonical regeneration. Generated files must be changed through their inputs/compiler; handwritten behavior remains in separate helpers.
The contributor guide and security model explicitly describe this intermediate next revision: legacy reporting workflow definitions and publisher code still exist until regeneration removes them, so their privileged boundaries remain in security-review scope. Correct the shifted large-payload policy citations too.
Validation
Basic review, comparison against merged main 28dce99, changed-path and referenced-file checks, and git diff --check passed. Only three handwritten documents change; no runtime, workflow, dependency, inventory, generation metadata, or release changes.