Skip to content

fix(cli): cancel bulk scan setup prompts - #974

Open
ianw-oai wants to merge 1 commit into
mainfrom
dev/ianw/cancel-bulk-scan-prompts
Open

ianw-oai wants to merge 1 commit into
mainfrom
dev/ianw/cancel-bulk-scan-prompts

Conversation

@ianw-oai

Copy link
Copy Markdown
Collaborator

Summary

bulk-scan could keep waiting for input after a termination signal. Its setup prompts did not receive the command's cancellation signal. The prompts now stop when the command is canceled.

Changes

  • Pass the signal to account selection, repository selection, output input, and start confirmation.
  • Use the existing test fixture to verify that the signal reaches each prompt.

Testing

  • Focused discovery tests: 12 passed; one Windows-only test skipped.
  • Type checks, compilation, formatting, and git diff --check: passed.
  • Full suite with seed 12345, before the test cleanup: 3,112 passed, 59 skipped, and two environment-related failures. Both failures passed when the publication tests were rerun with temporary state and process inspection access: 12 passed.
  • After the test cleanup, the focused tests, type checks, formatting, and diff check passed. The full suite was not repeated.

Risk and rollout

Low risk. Command syntax, defaults, and normal prompt behavior stay the same. No migration is required.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@ianw-oai
ianw-oai marked this pull request as ready for review September 18, 2026 23:23
@github-actions github-actions Bot added the bug Something isn't working label Sep 18, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 18, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review Completed 2026-09-18T23:25:52.706648Z ec761b6 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants