Skip to content

fix(ci): set up Python for Windows package verification - #966

Draft
mldangelo-oai wants to merge 3 commits into
mainfrom
mdangelo/codex/windows-package-python
Draft

mldangelo-oai wants to merge 3 commits into
mainfrom
mdangelo/codex/windows-package-python

Conversation

@mldangelo-oai

@mldangelo-oai mldangelo-oai commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

Windows installed-package verification invokes plugin code that needs Python. A Node 24 run failed with PluginPythonUnavailableError before the package behavior assertions. Separately, release-note reconciliation tests intermittently exceeded their subprocess timeout on Windows, which also failed the runner-inventory comparison.

Changes

  • Set up Python 3.12 before package verification for both Windows Node matrix entries. Reuse the same pinned action as the Windows test job.
  • Extend the existing workflow test to verify the shared action pin, interpreter version, PATH setup, and ordering before package inspection.
  • Use the existing 20-second Windows subprocess limit for the release-note reconciliation tests. Linux and macOS keep the 10-second limit.

Testing

  • PyYAML 6.0.3 parsed the workflow; Prettier 3.9.6 and git diff --check passed.
  • The workflow regression passed on Bun 1.3.13 and failed as expected against the previous workflow, which did not install Python in this job. All 25 release-note reconciliation cases passed on Bun 1.3.13 on macOS.
  • The SDK CI build, plugin bundle build, typechecks, and full formatting check passed.
  • On the previous PR head, Windows Node 22 and Node 24 package verification passed. Before the timeout change, different reconciliation cases exceeded 10 seconds in Windows baseline and Windows isolated. The original package-verification failure remains available for comparison. Fresh Windows CI will verify the updated branch.

Risk and rollout

This changes CI setup and test timing; production code and installed-package assertions are unchanged. The interpreter setup remains mandatory for both Windows Node versions. The original failure does not distinguish a missing interpreter from a failed interpreter probe.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@github-actions github-actions Bot added the bug Something isn't working label Sep 17, 2026
@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review exact head bfa9d93f92793b8fb7286c295009f7549334f8c7. This change reuses the existing pinned Python setup in Windows installed-package verification.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-17T22:18:38.721660Z bfa9d93 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: bfa9d93f92

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant