Skip to content

fix: report resolved Codex CLI version - #174

Open
pollychen-lab wants to merge 2 commits into
openai:mainfrom
pollychen-lab:agent/report-resolved-codex-version
Open

fix: report resolved Codex CLI version#174
pollychen-lab wants to merge 2 commits into
openai:mainfrom
pollychen-lab:agent/report-resolved-codex-version

Conversation

@pollychen-lab

Copy link
Copy Markdown

What this does

Fixes #171 by resolving the exact installed @openai/codex version once per run, surfacing it, and reusing it for the proxy install.

Why

When codex-version is left empty, the action currently installs whatever npm latest points to at run time. That means a workflow pinned to a specific action SHA can still execute a different Codex CLI on two runs of the same workflow.

This change makes that concrete and auditable:

  • adds a codex-version action output with the exact installed version
  • logs the resolved version during the install step
  • writes the resolved version into the GitHub step summary
  • documents that an empty input resolves latest at run time and should be pinned for reproducibility
  • reuses the exact resolved version when installing @openai/codex-responses-api-proxy

Validation

  • pnpm install --frozen-lockfile
  • pnpm test
  • git diff --check

@sylvesterkaczmarek sylvesterkaczmarek left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new exact-version handoff breaks supported range/tag inputs when the CLI and proxy publish sets differ. For example, >=0.58.0-alpha.9 <0.58.0-alpha.11 can resolve @openai/codex to 0.58.0-alpha.10, but that proxy version was never published (the proxy only has 0.58.0-alpha.9 in that range). Before this change each package resolved the input range independently; now the proxy install becomes @...proxy@0.58.0-alpha.10 and fails. Could the action report the exact CLI version without forcing the proxy to share it, or resolve/validate a compatible proxy version separately?

@pollychen-lab

Copy link
Copy Markdown
Author

The new exact-version handoff breaks supported range/tag inputs when the CLI and proxy publish sets differ. For example, >=0.58.0-alpha.9 <0.58.0-alpha.11 can resolve @openai/codex to 0.58.0-alpha.10, but that proxy version was never published (the proxy only has 0.58.0-alpha.9 in that range). Before this change each package resolved the input range independently; now the proxy install becomes @...proxy@0.58.0-alpha.10 and fails. Could the action report the exact CLI version without forcing the proxy to share it, or resolve/validate a compatible proxy version separately?

Hi @sylvesterkaczmarek thanks for catching that. I updated the PR so the action still reports the exact resolved @openai/codex CLI version, but the proxy install now uses the original codex-version input instead of the resolved CLI version.

@sylvesterkaczmarek sylvesterkaczmarek left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed the version handoff. The action now reports the exact installed CLI version as an output while the Responses proxy continues to resolve from the original codex-version input, so ranges/tags no longer require the CLI and proxy packages to have identical published version sets. The regression also pins that separation. My previous concern is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

codex-version defaults to empty, so a pinned action still installs an unpinned CLI

2 participants